Add praefect prometheus_exclude_database_from_default_metrics config value
What does this MR do?
Praefect has a new configuration value to control whether or not it will
hit the database for metrics. This change adds the
prometheus_exclude_database_from_default_metrics
config value and writes
it into the right place in the praefect config toml.
corresponding gitaly MR is gitaly!4085 (merged)
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened
Merge request reports
Activity
added devopssystems groupdistribution sectioncore platform labels
gitaly!4085 (merged) is still in progress and needs to be reviewed/merged. But, this is high priority so would be great to have it reviewed in parallel.
assigned to @jcaigitlab
added 9 commits
-
cb9550bb...d313af57 - 8 commits from branch
master
- 35d37fd9 - Add praefect prometheus_exclude_database_from_default_metrics config value
-
cb9550bb...d313af57 - 8 commits from branch
mentioned in merge request gitaly!4085 (merged)
added workflowready for review label
/cc @timzallmann
changed milestone to %14.5
The
Trigger:ee-package
job from pipeline https://gitlab.com/gitlab-org/omnibus-gitlab/-/pipelines/410909082 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/411026180 downstream.The
qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/411026180 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/411048706 downstream.The
gitlab-qa
downstream pipeline failed! .The qa failures appear unrelated to this MR, as they are also happening in master but the main failures are for gitaly-cluster tests: https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/jobs/1793870306 so not all the qa validation is working here
Thanks a lot @twk3 + team helping us on moving it forward.
added featureaddition label
removed featureaddition label
added featureenhancement label
added typefeature label
requested review from @twk3
added workflowin review label and removed workflowready for review label
- Resolved by DJ Mountney
Visually this looks good, I'm just doing some manual validation of the change now
mentioned in commit c489954f
added workflowstaging-canary label and removed workflowin review label
added workflowstaging-ref label and removed workflowstaging-canary label
added workflowstaging label and removed workflowstaging-ref label
added workflowcanary label and removed workflowstaging label
changed milestone to %14.6
added workflowproduction label and removed workflowcanary label
added Pick into 14.2 Pick into 14.3 Pick into 14.4 labels
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
picked the changes into the branch
14-2-stable-patch-7
with commit a92ad249mentioned in commit a92ad249
Automatically picked into !5750 (merged), will merge into
14-2-stable
ready for14.2.7
.removed Pick into 14.2 label
mentioned in merge request !5750 (merged)
picked the changes into the branch
14-3-stable-patch-5
with commit 29473df8mentioned in commit 29473df8
Automatically picked into !5752 (merged), will merge into
14-3-stable
ready for14.3.5
.removed Pick into 14.3 label
mentioned in merge request !5752 (merged)
mentioned in commit 4be6a278
picked the changes into the branch
14-4-stable-patch-3
with commit 4be6a278Automatically picked into !5762 (merged), will merge into
14-4-stable
ready for14.4.3
.removed Pick into 14.4 label
mentioned in merge request !5762 (merged)
mentioned in issue gitlab-org/release/tasks#3190 (closed)
Since gitaly!4107 (merged) landed in 14.5, I'll add Pick into 14.5 here too.
added Pick into 14.5 label
Never mind, this already landed in https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/14.5.0+ee.0/files/gitlab-cookbooks/praefect/attributes/default.rb.
changed milestone to %14.5
removed Pick into 14.5 label