Skip to content
Snippets Groups Projects

Add praefect prometheus_exclude_database_from_default_metrics config value

Merged John Cai requested to merge jc-add-separate-database-metrics into master
All threads resolved!

What does this MR do?

Praefect has a new configuration value to control whether or not it will hit the database for metrics. This change adds the prometheus_exclude_database_from_default_metrics config value and writes it into the right place in the praefect config toml.

corresponding gitaly MR is gitaly!4085 (merged)

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened

Merge request reports

Checking pipeline status.

Approved by

Merged by DJ MountneyDJ Mountney 3 years ago (Nov 17, 2021 10:21pm UTC)

Pipeline #411107961 passed

Pipeline passed for c489954f on master

7 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading