Remove deprecated `experimental_queue_selector` option for Sidekiq
What does this MR do?
This removes the deprecated experimental_queue_selector
option for Sidekiq, which is now simply called queue_selector
.
Related issues
gitlab-com/gl-infra/scalability#646
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened: gitlab-org/charts/gitlab!2023 (merged)
Merge request reports
Activity
changed milestone to %14.0
assigned to @smcgivern
mentioned in merge request gitlab-org/charts/gitlab!2023 (merged)
2 Warnings You've made some changes in the cookbooks, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding the ~"feature::maintenance" label in that case.You've made some changes at the locations which contain user facing configuration.
That's OK as long as you're refactoring existing code and not adding any new
configuration. If you are adding new user facing configuration, consider adding
to gitlab.rb.template located in files/gitlab-config-template/gitlab.rb.template .
Otherwise, please consider adding the ~"feature::maintenance" label in that case.1 Message Please add the workflowready for review label once you think the MR is ready to for an initial review. Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO.
If you don't receive a response, please mention
@gitlab-org/distribution
, or one of our Project MaintainersGenerated by
Dangermarked the checklist item Equivalent MR/issue for the GitLab Chart opened: gitlab-org/charts/gitlab!2023 (merged) as completed
added typemaintenance workflowready for review labels
added typefeature label
requested review from @balasankarc
- Resolved by Balasankar 'Balu' C
removed review request for @balasankarc
added workflowin review label and removed workflowready for review label
added 1 commit
- 02a2435e - Remove deprecated `experimental_queue_selector` option for Sidekiq
enabled an automatic merge when the pipeline for 02a2435e succeeds
mentioned in commit e61ff43c
mentioned in issue gitlab-com/gl-infra/scalability#1104
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
removed typefeature label
added workflowstaging-ref label and removed workflowproduction label
added workflowproduction label and removed workflowstaging-ref label