Remove option to refer to queue selector as experimental
In #147 (closed), we changed the --experimental-queue-selector
option to be just --queue-selector
, but we support either. In this issue, we can remove the old version. To do so, we'll need to grep for this issue (https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/646
) in:
- The Rails app.
- Omnibus.
- Charts.
- Our CNG images.
And remove / simplify as appropriate.
We also need to mention this in the monthly release post.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Sean McGivern added to epic &198
added to epic &198
- Sean McGivern added ServiceSidekiq workflow-infraProposal + 1 deleted label
added ServiceSidekiq workflow-infraProposal + 1 deleted label
- Sean McGivern changed the description
Compare with previous version changed the description
- Sean McGivern marked this issue as related to #147 (closed)
marked this issue as related to #147 (closed)
- 🤖 GitLab Bot 🤖 added 1 deleted label
added 1 deleted label
- Rachel Nienaber mentioned in issue #538
mentioned in issue #538
- Sean McGivern changed the description
Compare with previous version changed the description
- Sean McGivern mentioned in merge request gitlab-org/build/CNG!548 (merged)
mentioned in merge request gitlab-org/build/CNG!548 (merged)
- Rachel Nienaber added groupscalability label and removed 1 deleted label
added groupscalability label and removed 1 deleted label
- Rachel Nienaber removed 1 deleted label
removed 1 deleted label
- Developer
@smcgivern Can we set milestone of this one to %14.0 ?
Collapse replies - Author Contributor
@balasankarc we can, but our goal was probably to do this later than 14.0: &198 (comment 527957721)
Do you think that will be a problem?
- Developer
@smcgivern We warned in omnibus-gitlab that the flag will be removed in 14.0 - https://gitlab.com/gitlab-org/omnibus-gitlab/blob/703173d3b48a3aa8cd31494b759a61a7a50d9e92/files/gitlab-cookbooks/package/libraries/deprecations.rb#L106-117. Technically, I think we can let it run for few more releases and no one will complain about that, but when we eventually break it, we must expect at least one customer complaining.
😂 But if we want to continue letting it run after 14.0, we should update the file I linked above to say which version we pick. Else users who still have it won't be able to upgrade to 14.0. We have automatic guards in place to ensure that users don't try to run removed configuration.
- Author Contributor
@balasankarc OK, that sounds more like of a hard constraint for this one as we have codified the release. It isn't particularly hard to make this change, and it doesn't really leave us in an inconsistent state with &198, so I'll make sure to do this in 14.0. cc @rnienaber
- Author Contributor
Starting work on this now.
- Sean McGivern changed due date to May 28, 2021
changed due date to May 28, 2021
- Sean McGivern changed milestone to %14.0
changed milestone to %14.0
- Sean McGivern assigned to @smcgivern
assigned to @smcgivern
- Sean McGivern removed due date
removed due date
- Sean McGivern added workflow-infraIn Progress label and removed workflow-infraProposal label
added workflow-infraIn Progress label and removed workflow-infraProposal label
- Sean McGivern mentioned in merge request gitlab-org/omnibus-gitlab!5306 (merged)
mentioned in merge request gitlab-org/omnibus-gitlab!5306 (merged)
- Sean McGivern added workflow-infraUnder Review label and removed workflow-infraIn Progress label
added workflow-infraUnder Review label and removed workflow-infraIn Progress label
- Sean McGivern mentioned in merge request gitlab-org/charts/gitlab!2023 (merged)
mentioned in merge request gitlab-org/charts/gitlab!2023 (merged)
- Sean McGivern mentioned in merge request gitlab-org/build/CNG!679 (merged)
mentioned in merge request gitlab-org/build/CNG!679 (merged)
- Sean McGivern mentioned in merge request gitlab-org/gitlab!62697 (merged)
mentioned in merge request gitlab-org/gitlab!62697 (merged)
- Author Contributor
One groupdistribution MR left (charts: gitlab-org/charts/gitlab!2023 (merged)), then the Rails MR can go ahead and I can update the release post.
Collapse replies - Author Contributor
- Sean McGivern mentioned in merge request gitlab-com/www-gitlab-com!83959 (closed)
mentioned in merge request gitlab-com/www-gitlab-com!83959 (closed)
- Author Contributor
All the related MRs are merged, closing.
- Sean McGivern added workflow-infraDone label and removed workflow-infraUnder Review label
added workflow-infraDone label and removed workflow-infraUnder Review label
- Sean McGivern closed
closed
- Sean McGivern mentioned in issue gitlab-com/Product#3723 (closed)
mentioned in issue gitlab-com/Product#3723 (closed)