Skip to content

Use backup_keep_time to prune configuration backups

Jason Young requested to merge add-keeptime-to-backup-etc into master

What does this MR do?

This Merge Request borrows the pruning logic from the remove_old method in gitlab/lib/backup/manager.rb to make use of the gitlab_rails['backup_keep_time'] gitlab.rb to prune gitlab configuration backups saved to /etc/gitlab/config_backup

Related issues

#4689 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Robert Marshall

Merge request reports