Make Gitaly internal API calls go through Workhorse

This will not only help improve observability of API calls made by Gitaly, but it will also enable Gitaly to download LFS files via the API to support archive downloads (gitlab#15079 (closed)).

Closes #5666 (closed)

On a single-node Omnibus instance, this results in this change:

  * template[Create Gitaly config.toml] action create
    - update content in file /var/opt/gitlab/gitaly/config.toml from 9f6716 to d47295
    --- /var/opt/gitlab/gitaly/config.toml	2020-09-24 03:56:33.415040226 +0000
    +++ /var/opt/gitlab/gitaly/.chef-config20200924-15565-1x6fwe4.toml	2020-09-24 04:00:53.517609937 +0000
    @@ -36,7 +36,9 @@
     dir = "/opt/gitlab/embedded/service/gitlab-shell"

     [gitlab]
    -url = 'http://127.0.0.1:8080'
    +url = 'http+unix://%2Fvar%2Fopt%2Fgitlab%2Fgitlab-workhorse%2Fsocket'
    +relative_url_root = ''
    +

added 1 commit

• 61e56656 - Extract internal API code into WebServerHelper

Compare with previous version

added 62 commits

• 61e56656...ec76b387 - 60 commits from branch master
• 5aa17328 - Make Gitaly internal API calls go through Workhorse
• 537b1c40 - Extract internal API code into WebServerHelper

Compare with previous version

changed title from Sh route internal api workhorse to Make Gitaly internal API calls go through Workhorse

changed the description

changed milestone to %13.5

	2 Warnings
⚠	This merge request is missing any throughput labels.
⚠	You’ve made some changes at the locations which contain user facing configuration. That’s OK as long as you’re refactoring existing code and not adding any new configuration. If you are adding new user facing configuration, consider adding to gitlab.rb.template located in files/gitlab-config-template/gitlab.rb.template . Otherwise, please consider adding the ~”feature::maintenance” label in that case.

	1 Message
📖	Please add the ~”workflow::ready for review” label once you think the MR is ready to for an initial review. Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO. If you don’t receive a response, please mention @gitlab-org/distribution, or one of our Project Maintainers

Generated by 🚫 Danger

added Observability groupdistribution labels

added 1 commit

• 9c16014a - Extract internal API code into WebServerHelper

Compare with previous version

changed the description

assigned to @pursultani and unassigned @stanhu

The Trigger:ce-package job from pipeline https://gitlab.com/gitlab-org/omnibus-gitlab/-/pipelines/193786060 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/193853319 downstream.

The pipeline failure seems to be intermittent.

The Trigger:qa-test job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/193853319 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/193991047 downstream.

The gitlab-qa downstream pipeline failed! 💥.

Not related to this change.

mentioned in issue gitlab#15079 (closed)

Setting label(s) devopsenablement sectionenablement based on groupdistribution.

added devopssystems sectioncore platform labels

approved this merge request

LGTM. Thanks @stanhu. Passing it to @ibaum for the final review.