Disable crond if LetsEncrypt disabled
Previously the Omnibus-provided crond would still run if LetsEncrypt were enabled and then disabled later. This also goes for the auto-renew configuration. In both cases, crond is not needed, so we can disable the service if LetsEncrypt is not used. This also prevents stale configuration files from lingering.
While this isn't technically a regression, the upgrade of go-crond exposed this problem because the configuration flags changed, and Omnibus was no longer managing the runit files.
Closes #5541 (closed)
Merge request reports
Activity
added 1 commit
- b5f5c457 - Disable crond if LetsEncrypt auto-renew not enabled
changed milestone to %13.3
added Lets Encrypt typebug + 1 deleted label
assigned to @balasankarc
1 Warning You may want to add groupdistribution label to this MR for gitlab-insights 1 Message Please add the ~”workflow::ready for review” label once you think the MR is ready to for an initial review. Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our First-response SLO.
If you don’t receive a response, please mention
@gitlab-org/distribution
, or one of our Project MaintainersGenerated by
DangerEdited by 🤖 GitLab Bot 🤖mentioned in issue #5541 (closed)
- Resolved by Stan Hu
unassigned @balasankarc
added workflowready for review label
assigned to @balasankarc and unassigned @stanhu
added Stuff that should Just Work label