Inconsistencies between the syntaxes for configuring Gitaly Storage Locations
Configuring Gitaly has some interesting syntactic differences. The following is based on reading the community edition documentation for Gitaly and the charts documentation for stand-alone Gitaly.
The following syntax is always valid:
git_data_dirs({
'default' => {
'gitaly_address' => 'tcp://example.gitlab.com:8075'
}
})
git_data_dirs({
'default' => {
'path' => '/path/to/repositories/root'
}
})
The following syntax is only valid for paths:
gitaly['storage'] = [
{ 'name' => 'default', 'path' => '/path/to/repositories/root' }
]
It seems that, if gitaly['storage']
is not set then parse_gitaly_storages
will fix it up from a legacy setting.
I would expect this to work, but it does not, which leads me to believe it's not supported in GitalyClient
.
gitaly['storage'] = [
{ 'name' => 'default', 'gitaly_address' => 'tcp://example.gitlab.com:8075' }
]
Is this expected behavior?