Drop support for CE/EE detection via VERSION file in CI configuration
[Spinoff from !2918 (diffs, comment 125610956)]
Our "Is this a CE build or an EE build" check happens in two places
- In our code, to determine the type of package being built, specifying correct dependencies etc. This uses Build::Check.is_ee? method.
- In our CI configuration, to stop certain builds early. For example, RPi jobs exit early on EE builds, and SLES jobs do it early on CE builds. This is done by support/is_gitlab_ee.sh script.
Our requirement of latter is pretty limited, in the sense 99% of them can be satisfied by CI variables like CI_COMMIT_REF_NAME
and CI_TAG_NAME
and our ee
variable.
- Scheduled builds - uses
ee
variable - -stable, -stable-ee branch builds - can use
CI_COMMIT_REF_NAME
- -security, -security-ee branch builds - can use
CI_COMMIT_REF_NAME
- Releases - can use
CI_TAG_NAME
- Triggered builds - use
ee
variable.
The only usecase we won't support is someone having a foo
branch in omnibus-gitlab and bar-ee
in VERSION
file and expecting an EE package build. I don't think it is unreasonable to say "Set EE variable if you want an EE build". That way, we can simply drop the whole is_gitlab_ee.sh
thing and simply depend on only/except
for deciding which jobs should run where.
[To clarify: I am not proposing to drop support of using VERSION file for CE/EE detection in our rake tasks. We definitely need that. Suggestion is to drop it just from the CI configuration.]