Version string generation is incorrect
The version string generation done in !1399 (merged) fails for branch names that are actually valid version strings, for example 9-0-stable-ee
- https://dev.gitlab.org/gitlab/omnibus-gitlab/builds/951413.
Either we will have to bring back buildfrombranch
(rename it to buildfromgit
so that it indicates not only branch names, but also commit SHAs can be used) or find out a different way.
Usecases
- Version string with
v
prefix:v1.2.3
,v2.3.4
- Version string without
v
prefix:1.2.3
,2.3.4
- Branch name:
master
,9-0-stable
,0.5.0
- Commit SHA:
123qsdf24asdf1
One of the main problems is identifying if something is a tag or a branch name and whether a v
should be appended. For example, "0.5.0" can be either a tag, or a branch. If it is a tag, it can either be v0.5.0
or just 0.5.0
.