Skip to content

fix: removing pipeline exceptions

Jeff Parkrequested to merge
jpark/main/pipeline-exception into main

What does this merge request do and why?

This change removes PipelineExceptions from the pipeline.py file and lets the LLM fail gracefully when an MR, pipeline, or job are not found in the GitLab API. This change also removes logic in the ToolsExecutor to handle these PipelineExceptions. This approach of setting WorkflowStatusEnum.ERROR on a 404 from a tool isn't compatible with the rest of the codebase, causing checkpoints to set the workflow to FAILED when it actually should just recover gracefully from the tool response.

Related: gitlab-org/gitlab#558078 (closed)

How to set up and validate locally

  1. Check out this branch
  2. Ask WF to look at pipeline errors for a merge request that doesn't exist
  3. The WF should fail gracefully and not have the workflow end/crash.

Merge request checklist

  • Tests added for new functionality. If not, please raise an issue to follow up.
  • Documentation added/updated, if needed.

Merge request reports