Post review follow-ups for fforster/redis

Luke Hollindarequested to merge
lh-review-follow-up-fforster/redis into master

A couple minor refactor changes, addressing nitpick comments raised during review of: !551 (comment 3485733980)

Changes:

  • Iterate over strings.SplitSeq instead of strings.Split; avoiding a gopls diagnostic warning.
  • Adjust authnFormat interface to use named params for all methods.
  • Extract (p *authenticatedFormat) config() into a free function redisConfig(infra *infrastructure.Config); so that it can be used to deduplicate nil checks in noSecretFormat's functions as well.

Merge request reports