Remove unused keyword from EKS provision service
What does this MR do?
Fixes broken invocation of EKS provision service.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %12.8
added 1 commit
- 5b93c1f2 - Remove unused keyword from EKS provision service
marked the checklist item Changelog entry as completed
removed [deprecated] Accepting merge requests label
added 1 commit
- 086220f5 - Remove unused keyword from EKS provision service
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Ethan Urie ( @eurie
)Ash McKenzie ( @ashmckenzie
)Generated by
🚫 Danger- Resolved by Thong Kuah
Hey @proglottis can you please give this a quick review?
@tkuah would you be able to maintainer review & merge?
Thanks!
assigned to @tkuah and @proglottis and unassigned @tigerwnz
changed milestone to %12.7
unassigned @proglottis
mentioned in commit 520515e6
- Resolved by Tiger Watson
Thanks for this fix @tigerwnz ! Do we also want to add Pick into auto-deploy or wait for next weeks deploy ?
added Pick into auto-deploy label
removed Pick into auto-deploy label
mentioned in commit a2fa6336
This merge request has been deployed to the GitLab.com environment
gstg
in GitLab auto-deploy version12.7.202001090205-a2fa6336d7b.98ef8801a01
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd-cny
in GitLab auto-deploy version12.7.202001090205-a2fa6336d7b.98ef8801a01
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowcanary label and removed workflowstaging label
Automatically picked into !22674 (merged), will merge into
12-6-stable-ee
ready for12.6.3-ee
.mentioned in commit 4d03f9f8
mentioned in merge request !22674 (merged)
This merge request has been deployed to the GitLab.com environment
gprd
in GitLab auto-deploy version12.7.202001090505-e5c967cc40e.9bb76895a87
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowproduction label and removed workflowcanary label
mentioned in commit 7816adee
added groupenvironments label and removed groupconfigure [DEPRECATED] label