Reverts "Add RBAC permissions for getting knative version"
What does this MR do?
Reverts:
- 1408c633 (!20244 (merged))
- b452d6c9 (subsequent improvement)
- f0631507 (partial fix)
Fundamentally we should not be doing network calls in the unmet?
method as this method can be called within rails process. More importantly, this method is called during state transitions which means network calls increase the chances of exceptions dramatically.
Related issues: #55246 (closed) #118431 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
QA
Merge request reports
Activity
changed milestone to %12.7
added Pick into auto-deploy devopsconfigure [DEPRECATED] priority1 regression:12.6 severity2 typebug + 1 deleted label
- Resolved by Ash McKenzie
/cc @ali-gitlab @mattkasa @tigerwnz
@tigerwnz or @mattkasa Can at least one of you please review ?
added groupconfigure [DEPRECATED] label
- Resolved by Thong Kuah
This unfortunately does not apply cleanly to
12-6-stable-ee
, so will have to make a MR manually for it
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Mario de la Ossa ( @mdelaossa
)Peter Leitzen ( @splattael
)Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖marked the checklist item Changelog entry as completed
marked the checklist item Tested in all supported browsers as completed
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
assigned to @ashmckenzie
Thanks @tkuah LGTM
👍 mentioned in commit 5d2761a8
removed Pick into auto-deploy label
mentioned in commit 4388ccca
@ali-gitlab FYI - The revert has now been merged
@tkuah thanks. I've made the accompanying change to
gitlabktl
here: gitlabktl!95 (merged)
mentioned in issue #55246 (closed)
mentioned in commit 8c8277dd
mentioned in merge request !22597 (merged)
If/When ~"Pick into 12.6" does not work (because of a conflict), I have prepared !22597 (merged)
This merge request has been deployed to the GitLab.com environment
gstg
in GitLab auto-deploy version12.7.202001080605-4388ccca698.cc52a7de8e4
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd-cny
in GitLab auto-deploy version12.7.202001081105-fba6b21fe6b.66f0679493c
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowcanary label and removed workflowstaging label
mentioned in merge request gitlabktl!95 (merged)
This merge request has been deployed to the GitLab.com environment
gprd
in GitLab auto-deploy version12.7.202001081105-fba6b21fe6b.66f0679493c
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowproduction label and removed workflowcanary label
@@tkuah This merge request could not automatically be picked into
12-6-stable-ee
for12.6.3-ee
and will need manual intervention. You can either:- Create a new MR targeting the source branch of !22674 (merged), and assign to release managers, or
- Solve the conflicts against !22674 (merged), and reassign the ~"Pick into 12.6" label to this merge request.
Create a new MR targeting the source branch of !22674 (merged), and assign to release managers, or
This was already done on !22597 (merged)
mentioned in merge request !22674 (merged)
mentioned in issue gitlab-com/gl-infra/delivery#620 (closed)
mentioned in commit 67ce879a
mentioned in commit 38323577
mentioned in commit 7816adee
mentioned in issue #195998 (closed)
added groupenvironments label and removed groupconfigure [DEPRECATED] label