Skip to content
Snippets Groups Projects

Reverts "Add RBAC permissions for getting knative version"

Merged Thong Kuah requested to merge revert-knative-version-prerequisite into master
2 unresolved threads

What does this MR do?

Reverts:

Fundamentally we should not be doing network calls in the unmet? method as this method can be called within rails process. More importantly, this method is called during state transitions which means network calls increase the chances of exceptions dramatically.

Related issues: #55246 (closed) #118431 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

QA

See !22560 (comment 268372219)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading