Skip to content

!21542 Part 4: Check for file deleted and readded when getting file data

Himanshu Kapoor requested to merge 39498-part-4 into master

What does this MR do?

In getFileData, getRawFileData actions, and SET_FILE_RAW_DATA mutation, ignore the early returns for when a file is deleted and readded. This fixes issues with incorrect diff appearing because raw data wasn't loaded correctly for deleted and readded files.

This MR is the fourth part of the breakdown of MR !21542 (closed) and a fix for issue #39497 (closed).

This MR uses the getters defined in !21673 (merged).

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor

Merge request reports