Increased deactivation threshold to 180 days
What does this MR do?
Fixes #34692 (closed)
This MR extends the deactivation threshold introduced in 12.4 in !17037 (merged), #22257 (closed).
The need for this change was discussed at the E-Group Meeting on 2019-10-22 and discussed further on Slack. Stakeholders in GitLab are concerned that we don't understand the business implications of this change well enough to include this approach in our first iteration. There's a chance that the release of this feature could spur deactivations at scale, and since we haven't released a feature like this before - we can't accurately assert what impact this change will have.
Instead, our plan is to extend the deactivation threshold to a horizon that we feel is low-risk, take time to better understand the effects of this change, and then lower the threshold in the future when we understand the impact.
Since this MR reduces an unknown risk to GitLab's bottom line, we should consider this high priority and consider it for merging into the next patch release.
We've also merged in a handbook change to reduce the risk of this happening in the future: gitlab-com/www-gitlab-com!32994 (merged)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
2 Warnings ⚠ This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time. ⚠ This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Igor Drozdov ( @igor.drozdov
)Dmitriy 'DZ' Zaporozhets ( @dzaporozhets
)Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Jeremy Watson (ex-GitLab)
@lmcandrew @manojmj: As described in Slack, would you mind taking this MR from here if you feel comfortable moving forward with this change?
👍
added 1 commit
- 920f3f37 - Increased deactivation threshold to 180 days
added 1 commit
- ef581705 - Increased deactivation threshold to 180 days
marked the checklist item Documentation created/updated or follow-up review issue created as completed
marked the checklist item Changelog entry as completed
changed milestone to %12.4
@ifarkas could you please review? :)
assigned to @ifarkas
Thanks @manojmj, looks good to me!
mentioned in issue gitlab-com/www-gitlab-com#4230 (closed)
added typebug label and removed typefeature label
assigned to @tkuah
Hello @tkuah, could you please review? :)
marked the checklist item Code review guidelines as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
mentioned in commit fe9ddaa0
This merge request has been deployed to the GitLab.com environment
gstg
in GitLab auto-deploy version12.5.201910281129-c46489109e4.63e0b58bce3
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd-cny
in GitLab auto-deploy version12.5.201910281129-c46489109e4.63e0b58bce3
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowcanary label and removed workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd
in GitLab auto-deploy version12.5.201910281129-c46489109e4.63e0b58bce3
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowproduction label and removed workflowcanary label
mentioned in commit Dalahro/gitlab@4d1a3d31
Automatically picked into !19495 (merged), will merge into
12-4-stable-ee
ready for12.4.2-ee
.mentioned in commit 926c17d9
mentioned in merge request !19495 (merged)
mentioned in issue #7829 (closed)
mentioned in issue #37493 (closed)
mentioned in issue #201769 (closed)