Increase deactivation threshold to 180 days
Summary
The need for this change was discussed at the E-Group Meeting on 2019-10-22 and discussed further on Slack. Stakeholders in GitLab are concerned that we don't understand the business implications of this change well enough to include this approach in our first iteration. There's a chance that the release of this feature could spur deactivations at scale, and since we haven't released a feature like this before - we can't accurately assert what impact this change will have.
Instead, our plan is to extend the deactivation threshold to a horizon that we feel is low-risk, take time to better understand the effects of this change, and then lower the threshold in the future when we understand the impact.
Since this MR reduces an unknown risk to GitLab's bottom line, we should consider this high priority and consider it for merging into the next patch release.
We've also merged in a handbook change to reduce the risk of this happening in the future: gitlab-com/www-gitlab-com!32994 (merged)
Steps to reproduce
(How one can reproduce the issue - this is very important)
Example Project
(If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report)
(If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version)
What is the current bug behavior?
(What actually happens)
What is the expected correct behavior?
(What you should see instead)
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:env:info
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production
)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)