Add param to catch fo fix failing SAST job
What does this MR do?
Fixes syntax error in SAST job: https://gitlab.com/gitlab-org/gitlab/-/jobs/325522650
This is similar to what happened in gitlab-foss!29156 (diffs)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %12.5
@ashmckenzie can you review please?
I know this is frontend but I don't think we have APAC frontend maintainers right now. It's also a simple change that's the same with what we did before
🙂 assigned to @ashmckenzie
LGTM, thanks @engwan, MWPS set
👍 enabled an automatic merge when the pipeline for dcc65dea succeeds
1 Warning ⚠ This merge request changed files with disabled eslint rules. Please consider fixing them. Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/monitoring/utils.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/monitoring/utils.js'
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Lukas Eipert ( @leipert
)Mike Greiling ( @mikegreiling
)Generated by
🚫 Dangermentioned in commit 7dd2deb1
mentioned in issue gitlab-foss#67478 (moved)
mentioned in issue #35279 (closed)
mentioned in commit Dalahro/gitlab@4d1a3d31
Adding ~"Pick into 12.4" because of #35279 (closed).
Automatically picked into !19495 (merged), will merge into
12-4-stable-ee
ready for12.4.2-ee
.mentioned in commit 8fa7d4fb
mentioned in merge request !19495 (merged)