Fixes CSS leaks for job log
What does this MR do?
Fixes CSS leaks for job log. With the new job log refactor I created 2 CSS classes that already exist and broke the CSS. This MR updates those class names
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #32408 (closed)
Merge request reports
Activity
changed milestone to %12.3
1 Warning ⚠ You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~backstage, ~Documentation, QA labels.1 Message 📖 Consider setting merge_request
to 17484 in changelogs/unreleased/32408-fix-css-leak.yml. See the documentation.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Natalia Tepluhina ( @ntepluhina
)Kushal Pandya ( @kushalpandya
)Generated by
🚫 Danger@kushalpandya can you please review this one? Sorry about skipping the reviewer. Thanks!
assigned to @kushalpandya and unassigned @filipa
added Pick into auto-deploy label
enabled an automatic merge when the pipeline for 9faefa99 succeeds
mentioned in commit 704c35aa
mentioned in commit a07cf51d
removed Pick into auto-deploy label
mentioned in merge request !17485 (merged)
@kushalpandya @filipa I think this also needs a ~"Pick into 12.3"?
added priority1 + 1 deleted label
mentioned in issue #32403 (closed)
This merge request has been deployed to the GitLab.com environment
gstg
in GitLab auto-deploy version12.4.201909231220-a07cf51d7d1.3662ce781bc
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowstaging label
Automatically picked into !17540 (merged), will merge into
12-3-stable-ee
ready for12.3.1-ee
.mentioned in commit 70c10f89
mentioned in merge request !17540 (merged)
This merge request has been deployed to the GitLab.com environment
gprd-cny
in GitLab auto-deploy version12.4.201909240421-2d096e8234d.2888c83d378
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowcanary label and removed workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd
in GitLab auto-deploy version12.4.201909240421-2d096e8234d.2888c83d378
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowproduction label and removed workflowcanary label
This merge request has been deployed to the GitLab.com environment
gstg
in GitLab auto-deploy version12.4.201910011210-d42717d3ad0.477f92dfa6a
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowstaging label and removed workflowproduction label
This merge request has been deployed to the GitLab.com environment
gprd-cny
in GitLab auto-deploy version12.4.201910011210-d42717d3ad0.477f92dfa6a
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowcanary label and removed workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd
in GitLab auto-deploy version12.4.201910021004-f79c1794977.391a41dff5a
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowproduction label and removed workflowcanary label