Speed up log_execution_service_spec.rb
What does this MR do and why?
This MR speeds up spec/services/web_hooks/log_execution_service_spec.rb
.
Locally this change reduces the time the specs take to run from 1 minute 46.53 seconds
to 8.87 seconds
.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @.luke
added sectiondev + 1 deleted label
changed milestone to %15.5
added workflowin review label
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @reprazent
,@alexkalderimis
,@ntepluhina
,@acroitor
,@morefice
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tarun Vellishetty ( @tvellishetty
) (UTC+5.5, 6.5 hours behind@.luke
)Nikola Milojevic ( @nmilojevic1
) (UTC+2, 10 hours behind@.luke
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by Etienne Baqué
Hi, @Andysoiron! Could you please review this MR? Thank you!
requested review from @Andysoiron
requested review from @ebaque and removed review request for @Andysoiron
@Andysoiron
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for 13d5d38a succeeds