Skip to content

Hides cleanup policy admin notification while loading

What does this MR do and why?

Do not show "cleanup policies are disabled at admin level" notification while Container registry settings page is loading

Screenshots or screen recordings

The following highlighted parts should not be visible while loading

Main settings page Container Registry cleanup on new page
Screen_Shot_2022-09-06_at_15.29.56 Screen_Shot_2022-09-06_at_15.29.48

How to set up and validate locally

  1. Enable container registry in GDK https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/registry.md
  2. Login as admin
  3. Visit any project.
  4. Visit Settings > Packages & registries on the sidebar
  5. Make sure above notification is not visible when loading (you can also simulate slow network requests using the Chrome developer tools to confirm)
  6. Click on the link to 'Set up clean rules'
  7. Make sure above notification is not visible when loading

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #372874 (closed)

Edited by Rahul Chanila

Merge request reports