Introduce the Insights controllers
What does this MR do?
-
This first needs https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9912.
This implements a first iteration of the Insights controllers:
-
Insights configuration is fetched from the current project's .gitlab/insights.yml
or the from the group's Insights project's.gitlab/insights.yml
file -
For now, the Insights page displays the Insight config and the chart data, just for the sake of testing, until we plug the Frontend on it
What are the relevant issue numbers?
Closes #9867 (closed), https://gitlab.com/gitlab-org/gitlab-ee/issues/10421.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan? -
Security reports checked/validated by reviewer
Merge request reports
Activity
changed milestone to %11.9
4 Warnings This merge request is quite big (more than 674 lines changed), please consider splitting it into multiple merge requests. CHANGELOG missing. You can create one with:
bin/changelog -m 9776 "Introduce the Insights controllers"
If your merge request doesn’t warrant a CHANGELOG entry,
consider adding any of the ~backstage, ci-build, ~Documentation, meta, QA, test labels.
See the documentation.0d136be6: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. b89d7c4d: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Jan Provaznik ( @jprovaznik
)Robert Speicher ( @rspeicher
)frontend Enrique Alcántara ( @ealcantara
)Filipa Lacerda ( @filipa
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖mentioned in merge request !9791 (closed)
mentioned in issue #9869 (closed)
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
added 613 commits
-
770612ad...81d1e5c7 - 610 commits from branch
master
- 3a6c7109 - Introduce the Gitlab::Insights framework
- 9c1101f2 - Insights frontend
- 36a6c820 - Tweak the insights JS to supports line and pie charts
Toggle commit list-
770612ad...81d1e5c7 - 610 commits from branch
@godfat Thanks for the review! Unfortunately (for you), I've pushed an update which changed pretty much everything compared to the first version. I'm introducing an "Insights" framework:
- Finders
- Reducers
- Serializers
I've started to document it under
ee/lib/gitlab/insights/README.md
, you can even see Mermaids graphs here: https://gitlab.com/gitlab-org/gitlab-ee/blob/36a6c8203421ddc69b0b27e846cef674a3a7b987/ee/lib/gitlab/insights/README.mdThere are still some work to do here. Mainly:
- cleanup the controller
- add tests
- remove the JS part from the MR once it's ready. In the meantime, you can already review the backend part here: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9776/diffs?commit_id=3a6c71093e4c0fc8dcfc4af9789ca94b010938f8
- Resolved by Mark Fletcher
- Resolved by Mark Fletcher
added 59 commits
-
36a6c820...b04ce84f - 56 commits from branch
master
- f0ed3141 - Introduce the Gitlab::Insights framework
- 8bf9ad15 - Insights frontend
- aa7dd230 - Tweak the insights JS to supports line and pie charts
Toggle commit list-
36a6c820...b04ce84f - 56 commits from branch
added 181 commits
-
aa7dd230...b4695cbf - 179 commits from branch
master
- 320910e7 - Introduce the Gitlab::Insights framework
- cec8bfd2 - Introduce the Insights controllers
-
aa7dd230...b4695cbf - 179 commits from branch
mentioned in merge request !9912 (merged)
added 54 commits
-
cec8bfd2...6187ae7f - 52 commits from branch
master
- 85aa7b47 - Introduce the Gitlab::Insights framework
- c378b23c - Introduce the Insights controllers
-
cec8bfd2...6187ae7f - 52 commits from branch
added feature flag label
added 649 commits
-
c378b23c...811641dd - 648 commits from branch
master
- 8b6cdf19 - Introduce the Insights controllers
-
c378b23c...811641dd - 648 commits from branch
added 24 commits
-
8b6cdf19...f5db3aa7 - 23 commits from branch
master
- 0720dbae - Introduce the Insights controllers
-
8b6cdf19...f5db3aa7 - 23 commits from branch
- Resolved by Rémy Coutable
mentioned in issue #10421 (closed)
- Resolved by Rémy Coutable
added 71 commits
-
0720dbae...c62ac183 - 69 commits from branch
master
- a28061df - Introduce the Insights controllers
- 4dc3b9c2 - New Repository#insights_config method
-
0720dbae...c62ac183 - 69 commits from branch
marked the checklist item Tests added for this feature/bug as completed
mentioned in merge request !9856 (merged)
added 321 commits
-
4dc3b9c2...71589dc0 - 318 commits from branch
master
- 25d0b460 - Introduce a new EE::Repository#insights_config_for method
- 414b3d0f - Introduce a new InsightsFeature#insights_config method
- a057f188 - Introduce the Insights controllers
Toggle commit list-
4dc3b9c2...71589dc0 - 318 commits from branch
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
added 16 commits
-
d0464864...99d94583 - 13 commits from branch
master
- f83bda9a - Introduce a new EE::Repository#insights_config_for method
- d2a2fe65 - Introduce a new InsightsFeature#insights_config method
- 31670938 - Introduce the Insights controllers
Toggle commit list-
d0464864...99d94583 - 13 commits from branch
added 29 commits
-
31670938...bef05ab0 - 26 commits from branch
master
- e5869682 - Introduce a new EE::Repository#insights_config_for method
- f5ad5c47 - Introduce a new InsightsFeature#insights_config method
- 59c86ec1 - Introduce the Insights controllers
Toggle commit list-
31670938...bef05ab0 - 26 commits from branch