Remove ci_cost_factors_narrow_os_contribution_by_plan flag

What does this MR do and why?

Remove the ci_cost_factors_narrow_os_contribution_by_plan and document narrowing the scope of what is considered an open source contribution.

How to set up and validate locally

Example below:

1. Create a public project
2. Add it to the open source plan

   To do

3. Fork the project
4. Trigger a job with shared runners with a sleep script.
5. Cancel the job after a few minutes.
6. Check logs for .008 cost factor

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #372263 (closed)

changed milestone to %15.4

added Category:Continuous Integration devopsverify feature flag featureaddition grouppipeline execution sectionops typefeature workflowverification labels

assigned to @allison.browne

marked this merge request as ready

changed title from {-Draft: Resolve "[Feature flag] Rollout of -}ci_cost_factors_narrow_os_contribution_by_plan{-"-} to Remove ci_cost_factors_narrow_os_contribution_by_plan flag

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

changed the description

mentioned in commit f5c53637

added 1 commit

• f5c53637 - Narrow the definition of an OSS contribution

Compare with previous version

Suggested Reviewers (beta)

The individuals below may be good candidates to participate in the review based on various factors.

You can use slash commands in comments to quickly assign /assign_reviewer @user1.

Suggested Reviewers
@marcel.amirault, @vij, @mbobin, @allison.browne, @alyubenkov

If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

added backend documentation labels

	1 Message
📖	This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

Documentation review

The following files require a review from a technical writer:

• doc/ci/pipelines/cicd_minutes.md

The review does not need to block merging this merge request. See the:

• Metadata for the *.md files that you've changed. The first few lines of each *.md file identify the stage and group most closely associated with your docs change.
• The Technical Writer assigned for that stage and group.
• Documentation workflows for information on when to assign a merge request for review.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Jason Goodman (@jagood) (UTC-4, same timezone as @allison.browne)	Stan Hu (@stanhu) (UTC-7, 3 hours behind @allison.browne)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the 🔁 danger-review job that generated this comment.

Generated by 🚫 Danger

mentioned in issue #352830 (closed)

marked this merge request as draft

changed the description

Hey @morefice, could you do the backend review for me?

I;ve marked it draft due to the verification term.

requested review from @morefice

changed the description

Allure report

allure-report-publisher generated test report!

e2e-review-qa-blocking: ❗ test report for f5c53637

expand test summary

+-----------------------------------------------------------------------------------------+
|                                     suites summary                                      |
+------------------------------------+--------+--------+---------+-------+-------+--------+
|                                    | passed | failed | skipped | flaky | total | result |
+------------------------------------+--------+--------+---------+-------+-------+--------+
| Manage                             | 57     | 0      | 3       | 57    | 60    | ❗     |
| Secure                             | 2      | 0      | 0       | 2     | 2     | ❗     |
| Verify                             | 12     | 0      | 1       | 12    | 13    | ❗     |
| Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
| Create                             | 27     | 0      | 2       | 26    | 29    | ❗     |
| Plan                               | 47     | 0      | 1       | 47    | 48    | ❗     |
| Protect                            | 2      | 0      | 0       | 2     | 2     | ❗     |
| Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
| Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
| Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------------------------+--------+--------+---------+-------+-------+--------+
| Total                              | 156    | 0      | 10      | 146   | 166   | ❗     |
+------------------------------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: ❗ test report for f5c53637

expand test summary

+---------------------------------------------------------------------------+
|                              suites summary                               |
+----------------------+--------+--------+---------+-------+-------+--------+
|                      | passed | failed | skipped | flaky | total | result |
+----------------------+--------+--------+---------+-------+-------+--------+
| Manage               | 99     | 0      | 4       | 1     | 103   | ❗     |
| Release              | 4      | 0      | 0       | 0     | 4     | ✅     |
| Create               | 159    | 0      | 6       | 1     | 165   | ❗     |
| Fulfillment          | 2      | 0      | 11      | 0     | 13    | ✅     |
| Plan                 | 57     | 0      | 0       | 0     | 57    | ✅     |
| Verify               | 43     | 0      | 8       | 2     | 51    | ❗     |
| Secure               | 21     | 0      | 2       | 1     | 23    | ❗     |
| Configure            | 0      | 0      | 3       | 0     | 3     | ➖     |
| Package              | 0      | 0      | 3       | 0     | 3     | ➖     |
| Analytics            | 2      | 0      | 0       | 0     | 2     | ✅     |
| Version sanity check | 0      | 0      | 1       | 1     | 1     | ➖     |
| Protect              | 2      | 0      | 0       | 0     | 2     | ✅     |
+----------------------+--------+--------+---------+-------+-------+--------+
| Total                | 389    | 0      | 38      | 6     | 427   | ❗     |
+----------------------+--------+--------+---------+-------+-------+--------+

e2e-review-qa: ❗ test report for f5c53637

expand test summary

+-----------------------------------------------------------------------------------------+
|                                     suites summary                                      |
+------------------------------------+--------+--------+---------+-------+-------+--------+
|                                    | passed | failed | skipped | flaky | total | result |
+------------------------------------+--------+--------+---------+-------+-------+--------+
| Manage                             | 52     | 0      | 8       | 54    | 60    | ❗     |
| Plan                               | 47     | 0      | 1       | 18    | 48    | ❗     |
| Verify                             | 43     | 0      | 8       | 0     | 51    | ✅     |
| Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
| Create                             | 27     | 0      | 2       | 10    | 29    | ❗     |
| Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
| Secure                             | 2      | 0      | 0       | 0     | 2     | ✅     |
| Protect                            | 2      | 0      | 0       | 2     | 2     | ❗     |
| Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------------------------+--------+--------+---------+-------+-------+--------+
| Total                              | 182    | 0      | 22      | 84    | 204   | ❗     |
+------------------------------------+--------+--------+---------+-------+-------+--------+

approved this merge request