Introduce multiple Monitor support for the Watchdog
What does this MR do and why?
This MR extracts Monitoring logic from Watchdog.
This allows us to introduce multiple monitors to run within the watchdog.
We can even enable experimental monitors directly in the initializer and have different ones for Puma and Sidekiq.
Configuration:
watchdog = Gitlab::Memory::Watchdog.new
watchdog.configure do |config|
config.handler = Gitlab::Memory::Watchdog::NullHandler.instance
config.sleep_time_seconds = 30
# config.monitor.use MonitorClass, args**, &block
config.monitor.use Gitlab::Memory::Watchdog::Monitors::HeapFragmentationMonitor
config.monitor.use Gitlab::Memory::Watchdog::Monitors::MemoryGrowthMonitor
end
Gitlab::BackgroundTask.new(watchdog).start
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
related to: #379196 (closed)
Merge request reports
Activity
changed milestone to %15.4
requested review from @mkaeppler
assigned to @nmilojevic1
added devopsdata stores sectioncore platform labels
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @smcgivern
,@alipniagov
,@mkaeppler
,@robotmay_gitlab
,@stanhu
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot- A deleted user
added backend label
1 Warning This merge request is quite big (1263 lines changed), please consider splitting it into multiple merge requests. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Amparo Luna ( @a_luna
) (UTC-5, 7 hours behind@nmilojevic1
)Jan Provaznik ( @jprovaznik
) (UTC+2, same timezone as@nmilojevic1
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermentioned in merge request !96241 (merged)
mentioned in merge request !95911 (closed)
mentioned in issue #370239 (closed)
mentioned in issue #368692 (closed)
mentioned in issue #368399 (closed)
mentioned in epic &8415 (closed)