Skip to content
Snippets Groups Projects

Fix group authorization when searching for epics

Merged Felipe Cardozo requested to merge issue_371067 into master

What does this MR do and why?

Follow up of !93601 (merged).

On the MR above I forgot to take into account projects that are visible to the user to get authorized groups, in other words, if a group has a project all group members can read ancestor groups.

More details at #371067 (closed)

This changes one of the queries of the union introduced by !93601 (merged), it gets a bit worse performance-wise, but we need to keep the same behavior from before at least until we remove this authorization inconsistency.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Felipe Cardozo

Merge request reports

Merged results pipeline #627850621 passed

Pipeline: GitLab

#627922712

    Merged results pipeline passed for f9f29eed

    Test coverage 83.48% (11.82%) from 2 jobs

    Merged by Steve AbramsSteve Abrams 2 years ago (Aug 31, 2022 5:41pm UTC)

    Loading

    Pipeline #627974036 passed

    Pipeline passed for 54678818 on master

    Test coverage 71.69% (11.82%) from 2 jobs
    10 environments impacted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    Please register or sign in to reply
    Loading