Skip to content
Snippets Groups Projects

Add support for nesting GLFM examples in H3s

Merged Chad Woolley requested to merge caw-add-glfm-h3-example-support into master

What does this MR do and why?

Related: Tracking Issue: Implement GLFM scripts per the ... (#361241 - closed)

Allows GitLab Flavored Markdown examples in the glfm_canonical_examples.txt file to be nested within H3 headings.

Previously they could only be nested with H2 headings.

Also adds a corresponding third-level to the automatic hierarchical numbering of examples in the GLFM Example Snapshot files.

See also docs on update-example-snapshots.rb script: https://docs.gitlab.com/ee/development/gitlab_flavored_markdown/specification_guide/#update-example-snapshotsrb-script

Tasks

  • Add logic supporting H3s
  • Update corresponding docs
  • Update all existing example snapshot files to new format

How to set up and validate locally

  1. Run scripts/glfm/update-example-snapshots.rb and ensure there are no failures or changes (expected changes to *.yml files may occur after a rebase).
  2. Review documentation changes in the MR for correctness.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Chad Woolley

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chad Woolley
  • Chad Woolley
  • Chad Woolley marked this merge request as ready

    marked this merge request as ready

  • mentioned in issue #361241 (closed)

  • Chad Woolley changed the description

    changed the description

  • @morefice Would you like to take the first review for this, since you have already looked at this code before in Add some clarification to GLFM fixture (!94905 - merged)?

    Note that there's only small amount of logic changes to two files, and the corresponding specs.

    All of the other changes in *.yml files are due to the third level of hierarchy numbering being added for the examples. These are separated in a second commit for clarity (but this can be squashed down when merged).

  • Chad Woolley requested review from @morefice

    requested review from @morefice

  • Chad Woolley added 1288 commits

    added 1288 commits

    Compare with previous version

  • Chad Woolley marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Chad Woolley changed the description

    changed the description

  • Max Orefice
    • Resolved by Doug Stull

      @cwoolley-gitlab

      Thanks this LGTM :thumbsup:

      Note that there's only small amount of logic changes to two files, and the corresponding specs.

      It would be great to prioritize the refactoring of this class in smaller methods for better maintainability, looks like this is already on your radar.


      :wave: @dstull could you review this MR please?

  • Max Orefice approved this merge request

    approved this merge request

  • Max Orefice requested review from @dstull and removed review request for @morefice

    requested review from @dstull and removed review request for @morefice

  • :wave: @morefice, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Chad Woolley mentioned in commit 812ed197

    mentioned in commit 812ed197

  • Chad Woolley added 122 commits

    added 122 commits

    Compare with previous version

  • Chad Woolley mentioned in commit 4091bd02

    mentioned in commit 4091bd02

  • Chad Woolley added 2 commits

    added 2 commits

    • 4091bd02 - Add support for GLFM examples in H3s
    • 61eebd74 - Run scripts/glfm/update-example-snapshots.rb

    Compare with previous version

  • Chad Woolley mentioned in commit 50fa424e

    mentioned in commit 50fa424e

  • Chad Woolley added 2 commits

    added 2 commits

    • 50fa424e - Add support for GLFM examples in H3s
    • 14a71c2a - Run scripts/glfm/update-example-snapshots.rb

    Compare with previous version

  • Doug Stull
  • Doug Stull approved this merge request

    approved this merge request

  • Doug Stull resolved all threads

    resolved all threads

  • Doug Stull enabled an automatic merge when the pipeline for 09b163a0 succeeds

    enabled an automatic merge when the pipeline for 09b163a0 succeeds

  • merged

  • Chad Woolley mentioned in commit b0f9cbc8

    mentioned in commit b0f9cbc8

  • Doug Stull mentioned in commit b2248031

    mentioned in commit b2248031

  • Chad Woolley resolved all threads

    resolved all threads

  • added workflowstaging label and removed workflowcanary label

  • Chad Woolley mentioned in commit 8ef9a8e2

    mentioned in commit 8ef9a8e2

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading