Rucobop: Fix RSpec/EmptyLineAfterExample offences
What does this MR do and why?
As a follow-up to !94994 (merged), this MR is the result of running auto-correction for the RSpec/EmptyLineAfterExample
cop.
Related to #42182 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.3
added grouprelease [DEPRECATED] label
assigned to @ali-gitlab
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@rymai
,@marin
,@mayra-cabrera
,@engwan
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
1 Warning ada27141: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Roy Zwambag ( @rzwambag
) (UTC+2, 6 hours ahead of@ali-gitlab
)Steve Abrams ( @sabrams
) (UTC-6, 2 hours behind@ali-gitlab
)QA Désirée Chevalier ( @dchevalier2
) (UTC-4, same timezone as@ali-gitlab
)Maintainer review is optional for QA test for spec/features/*
Roy Zwambag ( @rzwambag
) (UTC+2, 6 hours ahead of@ali-gitlab
)Maintainer review is optional for test for spec/features/*
~"Compliance" Reviewer review is optional for ~"Compliance" Sascha Eggenberger ( @seggenberger
) (UTC+2, 6 hours ahead of@ali-gitlab
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
@ali-gitlab - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, typemaintenance or a subtype label to this merge request.
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for ada27141expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 28 | 29 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Manage | 46 | 0 | 3 | 39 | 49 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 9 | 9 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 146 | 0 | 9 | 139 | 155 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
review-qa-all:
test report for ada27141expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Secure | 18 | 0 | 3 | 20 | 21 | ❗ | | Create | 126 | 0 | 6 | 126 | 132 | ❗ | | Plan | 6 | 0 | 3 | 6 | 9 | ❗ | | Verify | 33 | 0 | 2 | 33 | 35 | ❗ | | Manage | 45 | 2 | 3 | 47 | 50 | ❌ | | Release | 5 | 0 | 0 | 5 | 5 | ❗ | | Fulfillment | 0 | 0 | 13 | 0 | 13 | ➖ | | Analytics | 1 | 0 | 1 | 1 | 2 | ❗ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 234 | 2 | 35 | 238 | 271 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
package-and-qa:
test report for ada27141expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 983 | 1 | 24 | 33 | 1008 | ❌ | | Plan | 350 | 0 | 0 | 1 | 350 | ❗ | | Secure | 120 | 0 | 18 | 9 | 138 | ❗ | | Manage | 616 | 0 | 18 | 83 | 634 | ❗ | | Verify | 272 | 0 | 18 | 2 | 290 | ❗ | | Analytics | 13 | 0 | 0 | 0 | 13 | ✅ | | Fulfillment | 14 | 0 | 67 | 1 | 81 | ❗ | | Release | 30 | 0 | 0 | 0 | 30 | ✅ | | Package | 169 | 6 | 21 | 2 | 196 | ❌ | | Configure | 1 | 0 | 18 | 0 | 19 | ✅ | | Version sanity check | 0 | 0 | 6 | 0 | 6 | ➖ | | Protect | 12 | 0 | 0 | 0 | 12 | ✅ | | Enablement:Search | 10 | 0 | 1 | 0 | 11 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 3 | 3 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 2592 | 7 | 192 | 134 | 2791 | ❌ | +----------------------+--------+--------+---------+-------+-------+--------+
Setting label(s) ~"devops::release" sectionops based on ~"group::release".
added devopsrelease [DEPRECATED] sectionops labels
added pipeline:run-as-if-foss label
- The
gitlab-qa-mirror
downstream pipeline for !95228 (bc084c11) failed! - The
gitlab-qa-mirror
downstream pipeline for !95228 (bc084c11) failed! - The
gitlab-qa-mirror
downstream pipeline for !95228 (bc084c11) passed. - The
gitlab-qa-mirror
downstream pipeline for !95228 (bc084c11) failed! - The
gitlab-qa-mirror
downstream pipeline for !95228 (bc084c11) passed. - The
gitlab-qa-mirror
downstream pipeline for !95228 (82efb885) failed! - The
gitlab-qa-mirror
downstream pipeline for !95228 (82efb885) failed! - The
gitlab-qa-mirror
downstream pipeline for !95228 (ada27141) passed. - The
gitlab-qa-mirror
downstream pipeline for !95228 (ada27141) failed! - The
gitlab-qa-mirror
downstream pipeline for !95228 (ada27141) passed. - The
gitlab-qa-mirror
downstream pipeline for !95228 (ada27141) failed!
- The
added maintenanceworkflow label
added typemaintenance label
added static code analysis label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Steve Abrams
@vshumilo can you please review this? Thanks!
requested review from @vshumilo
added 236 commits
-
bc084c11...c96cda2b - 235 commits from branch
master
- 82efb885 - Rucobop: Fix RSpec/EmptyLineAfterExample offences
-
bc084c11...c96cda2b - 235 commits from branch
added 174 commits
-
82efb885...6f18f657 - 173 commits from branch
master
- ada27141 - Rucobop: Fix RSpec/EmptyLineAfterExample offences
-
82efb885...6f18f657 - 173 commits from branch
@vshumilo
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @rob.hunt
removed review request for @sabrams
enabled an automatic merge when the pipeline for 1803d6c7 succeeds
mentioned in commit 73366364
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label