Update gitlab-styles to 3.1.0 / reenable cops
Summary
The cops below were disabled because they caused violations in the upgrade to gitlab-styles
3.1.0 (!21886 (merged)). I will be re-enabling them in small chunks in separate MRs.
Cop | MR |
---|---|
FactoryBot/FactoryClassName | !22136 (merged) |
FactoryBot/CreateList | !22136 (merged) |
Rails/SafeNavigationWithBlank | !23101 (merged) |
Rails/ApplicationController | !23101 (merged) |
Rails/ApplicationMailer | !23101 (merged) |
Rails/RakeEnvironment | !23101 (merged) |
Rails/HelperInstanceVariable | !23101 (merged) |
Rails/EnumHash | !23101 (merged) |
RSpec/ReceiveCounts | !23456 (merged) |
RSpec/ContextMethod | !23456 (merged) |
RSpec/ImplicitSubject | !25025 (closed) |
RSpec/LeakyConstantDeclaration | #211580 |
RSpec/EmptyLineAfterHook | !95147 (merged) |
RSpec/HooksBeforeExamples | !95251 (merged) |
RSpec/EmptyLineAfterExample | !94994 (merged) |
RSpec/Be | !95451 (merged) |
RSpec/SharedExamples | !95569 (merged) |
RSpec/EmptyLineAfterExampleGroup | !95674 (merged) |
RSpec/DescribedClass | !95795 (merged) |
RSpec/ReceiveNever | !95828 (merged) |
RSpec/ExampleWording | |
RSpec/MissingExampleGroupArgument | !95894 (merged) |
RSpec/UnspecifiedException | !95997 (merged) |
Style/HashSyntax | |
Style/WordArray | |
Style/MultilineWhenThen | |
Style/FloatDivision | !96132 (merged) |
Improvements
Risks
Involved components
Optional: Intended side effects
Optional: Missing test coverage
Edited by Max Orefice