Skip to content

Fix search catetory known events location

What does this MR do and why?

This MR is follow up to !90237 (merged) It fixes search known events category enabling it to be collected with instrumentation classes framework

Broken metrics for search category EE only metrics were instrumented in CE code resulting in failing build for CE. If metric has metric definition YAML file in EE only, it will be filtered out from Service Ping payload on CE regardless if metric is instrumented in CE

Relates #338463 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

pry(main)> ::Feature.enable(:use_redis_hll_instrumentation_classes)

pry(main)> ServicePing::BuildPayload.new.execute["redis_hll_counters"]["search"]
=> {"i_search_paid_weekly"=>0,
 "i_search_advanced_weekly"=>0,
 "i_search_paid_monthly"=>0,
 "i_search_advanced_monthly"=>0,
 "search_total_unique_counts_weekly"=>0,
 "i_search_total_weekly"=>0,
 "search_total_unique_counts_monthly"=>0,
 "i_search_total_monthly"=>0}

pry(main)> ::Feature.disable(:use_redis_hll_instrumentation_classes)

pry(main)> payload  =  ServicePing::BuildPayload.new.execute["redis_hll_counters"]["search"]
=> {"i_search_total_weekly"=>0,
 "i_search_total_monthly"=>0,
 "i_search_advanced_weekly"=>0,
 "i_search_advanced_monthly"=>0,
 "i_search_paid_weekly"=>0,
 "i_search_paid_monthly"=>0,
 "search_total_unique_counts_weekly"=>0,
 "search_total_unique_counts_monthly"=>0}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mikołaj Wawrzyniak

Merge request reports