Resolve "Illegal instruction in json.rb after upgrade to 15.2.0-ce"
What does this MR do and why?
We upgraded OJ to 3.13.16, but it seems 3.13.15 added breaking changes (https://github.com/ohler55/oj/issues/789). 3.13.17 addresses the issue partially, so we are upgrading to that.
Screenshots or screen recordings
For reproducing, this would require a CPU without support SSE4.2, we are relying on tests passing for no degradation.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #368656 (closed)
Merge request reports
Activity
changed milestone to %15.3
assigned to @eduardobonet
- Resolved by 🤖 GitLab Bot 🤖
@eduardobonet - please add typebug typefeature, typemaintenance or a subtype label to this merge request.- typebug: Defects in shipped code and fixes for those defects. This includes all the bug types (availability, performance, security vulnerability, mobile, etc.)
- typefeature: Effort to deliver new features, feature changes & improvements. This includes all changes as part of new product requirements like application limits.
- typemaintenance: Up-keeping efforts & catch-up corrective improvements that are not Features nor Bugs. This includes restructuring for long-term maintainability, stability, reducing technical debt, improving the contributor experience, or upgrading dependencies.
See the handbook for more guidance on classifying.
This message was created with automation and Engineering Productivity is looking for feedback in this issue:
https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues/43
added bugavailability typebug labels
added SingleEngineerGroup groupincubation labels
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@mayra-cabrera
,@jivanvl
,@godfat
,@ahegyi
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
- A deleted user
added backend label
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tyler Amos ( @tyleramos
) (UTC-4, 6 hours behind@eduardobonet
)Dmitry Gruzd ( @dgruzd
) (UTC+2, same timezone as@eduardobonet
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @egrieff
@egrieff
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added Pick into 15.2 label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
enabled an automatic merge when the pipeline for 5aa2bda7 succeeds
- Resolved by Stan Hu
requested review from @stanhu
added severity2 label
added priority1 label
mentioned in commit 005fc113
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
picked the changes into the branch
15-2-stable-ee-patch-2
with commit 5c38e22cAutomatically picked into !93652 (merged), will merge into
15-2-stable-ee
ready for15.2.2-ee
.mentioned in commit 5c38e22c
removed Pick into 15.2 label
mentioned in merge request !93652 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label