Skip to content
Snippets Groups Projects

Event type info in group deploy token audit events

What does this MR do and why?

Add event type information in streaming audit event while creation and revoking group deploy token

action event type
creation group_deploy_token_created
revoke group_deploy_token_revoked
delete group_deploy_token_destroyed
creation failed group_deploy_token_creation_failed

How to set up and validate locally

  1. Create a deploy token from Group -> Settings -> Repository.
  2. Check streamed audit event contains correct event type information both in payload and headers.
  3. Check audit event is saved in database and is visible at {{base url}}/admin/audit_logs.
  4. Revoke a deploy token from UI.
  5. Repeat step 2 and 3.
  6. Create Deploy token using API https://docs.gitlab.com/ee/api/deploy_tokens.html#create-a-group-deploy-token
  7. Repeat step 2 and 3
  8. Delete Deploy token using API https://docs.gitlab.com/ee/api/deploy_tokens.html#delete-a-group-deploy-token
  9. Repeat step 2 and 3

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #363087 (closed)

Edited by Harsimar Sandhu

Merge request reports

Merged results pipeline #602500824 passed

Merged results pipeline passed for b02fb7d7

Test coverage 83.34% (11.92%) from 2 jobs
Approval is optional

Merged by Thong KuahThong Kuah 2 years ago (Aug 2, 2022 9:12am UTC)

Merge details

  • Changes merged into master with 1393bcb9 (commits were squashed).
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #602567141 passed

Pipeline passed for 1393bcb9 on master

Test coverage 71.39% (11.92%) from 2 jobs
10 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Magdalena Frankiewicz approved this merge request

    approved this merge request

  • Magdalena Frankiewicz requested review from @tkuah and removed review request for @m_frankiewicz

    requested review from @tkuah and removed review request for @m_frankiewicz

  • :wave: @m_frankiewicz, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Harsimar Sandhu marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Thong Kuah
  • Great review @m_frankiewicz !

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading