Skip to content
Snippets Groups Projects

Event type info in group deploy token audit events

All threads resolved!

What does this MR do and why?

Add event type information in streaming audit event while creation and revoking group deploy token

action event type
creation group_deploy_token_created
revoke group_deploy_token_revoked
delete group_deploy_token_destroyed
creation failed group_deploy_token_creation_failed

How to set up and validate locally

  1. Create a deploy token from Group -> Settings -> Repository.
  2. Check streamed audit event contains correct event type information both in payload and headers.
  3. Check audit event is saved in database and is visible at {{base url}}/admin/audit_logs.
  4. Revoke a deploy token from UI.
  5. Repeat step 2 and 3.
  6. Create Deploy token using API https://docs.gitlab.com/ee/api/deploy_tokens.html#create-a-group-deploy-token
  7. Repeat step 2 and 3
  8. Delete Deploy token using API https://docs.gitlab.com/ee/api/deploy_tokens.html#delete-a-group-deploy-token
  9. Repeat step 2 and 3

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #363087 (closed)

Edited by Harsimar Sandhu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Magdalena Frankiewicz approved this merge request

    approved this merge request

  • Magdalena Frankiewicz requested review from @tkuah and removed review request for @m_frankiewicz

    requested review from @tkuah and removed review request for @m_frankiewicz

  • :wave: @m_frankiewicz, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Harsimar Sandhu marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Thong Kuah
  • Great review @m_frankiewicz !

  • Thong Kuah removed review request for @tkuah

    removed review request for @tkuah

  • Harsimar Sandhu requested review from @tkuah

    requested review from @tkuah

  • Thong Kuah approved this merge request

    approved this merge request

  • Thong Kuah resolved all threads

    resolved all threads

  • Thong Kuah enabled an automatic merge when the pipeline for 4dcd2d23 succeeds

    enabled an automatic merge when the pipeline for 4dcd2d23 succeeds

  • Harsimar Sandhu aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Harsimar Sandhu added 1241 commits

    added 1241 commits

    Compare with previous version

  • @tkuah Could you please hit merge button again, I took rebase with master as pipeline was failing.

  • Thong Kuah enabled an automatic merge when the pipeline for b02fb7d7 succeeds

    enabled an automatic merge when the pipeline for b02fb7d7 succeeds

  • merged

  • Thong Kuah mentioned in commit 1393bcb9

    mentioned in commit 1393bcb9

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #373952 (closed)

  • Please register or sign in to reply
    Loading