Event type info in group deploy token audit events
What does this MR do and why?
Add event type information in streaming audit event while creation and revoking group deploy token
action | event type |
---|---|
creation | group_deploy_token_created |
revoke | group_deploy_token_revoked |
delete | group_deploy_token_destroyed |
creation failed | group_deploy_token_creation_failed |
How to set up and validate locally
- Create a deploy token from Group -> Settings -> Repository.
- Check streamed audit event contains correct event type information both in payload and headers.
- Check audit event is saved in database and is visible at {{base url}}/admin/audit_logs.
- Revoke a deploy token from UI.
- Repeat step 2 and 3.
- Create Deploy token using API https://docs.gitlab.com/ee/api/deploy_tokens.html#create-a-group-deploy-token
- Repeat step 2 and 3
- Delete Deploy token using API https://docs.gitlab.com/ee/api/deploy_tokens.html#delete-a-group-deploy-token
- Repeat step 2 and 3
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #363087 (closed)
Merge request reports
Activity
changed milestone to %15.3
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @mwoolf
,@eread
,@reprazent
,@alberts-gitlab
,@rpereira2
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
- A deleted user
added backend label
1 Warning Please add a merge request subtype to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Alan (Maciej) Paruszewski ( @mparuszewski
) (UTC+2, 3.5 hours behind@harsimarsandhu
)Charlie Ablett ( @cablett
) (UTC+12, 6.5 hours ahead of@harsimarsandhu
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerassigned to @harsimarsandhu
- Resolved by Thong Kuah
@m_frankiewicz Could you please review backend
requested review from @m_frankiewicz
removed workflowproduction label
removed Next Up label
- Resolved by Thong Kuah
requested review from @tkuah and removed review request for @m_frankiewicz
@m_frankiewicz
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Thong Kuah
- Resolved by Thong Kuah
Thanks @harsimarsandhu ! I have one question above, though I'm not sure what it does exactly, but seems important :)
Edited by Thong Kuah
Great review @m_frankiewicz !
removed review request for @tkuah
requested review from @tkuah
enabled an automatic merge when the pipeline for 4dcd2d23 succeeds
added 1241 commits
-
caa7a4cf...6bab48a5 - 1240 commits from branch
master
- 71ff84ca - Event type info in group deploy token audit events
-
caa7a4cf...6bab48a5 - 1240 commits from branch
@tkuah Could you please hit merge button again, I took rebase with master as pipeline was failing.
enabled an automatic merge when the pipeline for b02fb7d7 succeeds
mentioned in commit 1393bcb9
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1303 (merged)
mentioned in issue #373952 (closed)