Skip to content

gitaly_client: Handle structured errors returned by FindTag RPC

Steve Xuereb - Out of Office Back 2024-06-16 requested to merge fix/find-tag-not-found into master

What does this MR do and why?

The FindTag RPC is currently returning an Internal error when a tag wasn't found. So even though this error case is expected, it still impacts our SLIs. To fix this, Gitaly is about to introduce a new structured FindTagError so that it can tell clients about the error condition that a tag wasn't found. It will then convert the RPC to use an NotFound error code to stop impacting our SLIs.

Reference gitaly#4366 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Patrick Steinhardt

Merge request reports