Skip to content

Fix compliance category Redis Hll metrics

Mikołaj Wawrzyniak requested to merge mwaw/fix_compliance_known_events_definitions_338463 into master

What does this MR do and why?

This MR is follow up to !90237 (merged) It fixes compliance known events category enabling it to be collected with instrumentation classes framework.

Service Ping metric definition for compliance category are all located in EE directory. Because of that those metrics are only reported from EE instances. However known events definitions for events in compliance category was placed in CE, that caused problems during migration to instrumentation classes framework. This MR aligns known events according to metrics definitions.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Compare payload from master and current branch to notice that there is no difference

pry(main)> ::Feature.enable(:use_redis_hll_instrumentation_classes)
pry(main)> ServicePing::BuildPayload.new.execute["redis_hll_counters"]["compliance"]
=> {"a_compliance_audit_events_api_weekly"=>0,
 "a_compliance_audit_events_api_monthly"=>0,
 "g_compliance_audit_events_weekly"=>0,
 "g_compliance_audit_events_monthly"=>0,
 "g_compliance_dashboard_weekly"=>0,
 "g_compliance_dashboard_monthly"=>0,
 "i_compliance_audit_events_weekly"=>0,
 "i_compliance_audit_events_monthly"=>0,
 "i_compliance_credential_inventory_weekly"=>0,
 "i_compliance_credential_inventory_monthly"=>0,
 "compliance_total_unique_counts_weekly"=>0,
 "compliance_total_unique_counts_monthly"=>0}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Relates to #338463 (closed)

Edited by Mikołaj Wawrzyniak

Merge request reports