Resolve "Geo: Optimize replication of project repo keep around refs"

What does this MR do and why?

This MR avoids triggering Repositories::KeepAroundRefsCreatedEvent event on keep_around method when no SHAs are passed. If there are no SHAs then there is no write_ref call: https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/git/keep_around.rb#L21-32

How to set up and validate locally

1. In the secondary site, tail geo.log
2. Comment on an issue.
3. Observe logs, there shouldn't be any log like the following one: {"severity":"INFO","time":"2022-05-19T00:50:32.648Z","correlation_id":null,"pid":50126,"host":"127.0.0.1","class":"Gitlab::Geo::LogCursor::Daemon","message":"Repository update","project_id":6,"source":"repository","resync_repository":true,"resync_wiki":false,"scheduled_at":"2022-05-18T17:50:32.629-07:00","replicable_project":true,"job_id":"d7d2a28e31b6840ff61a69fe","event_id":2,"cursor_delay_s":0.51}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #362851 (closed)

changed milestone to %Backlog

added Enterprise Edition GitLab Premium bugperformance devopssystems groupgeo priority4 sectioncore platform severity4 typebug workflowplanning breakdown + 1 deleted label

assigned to @jbobadilla-ext

removed workflowplanning breakdown label

added workflowin dev label

changed milestone to %15.3

added 1547 commits

• 657bcc98...fba605d4 - 1546 commits from branch master
• d765a06d - Trigger KeepAroundRefsCreatedEvent event only if SHAs are passed

Compare with previous version

Suggested Reviewers (beta)

The individuals below may be good candidates to participate in the review based on various factors.

You can use slash commands in comments to quickly assign /assign_reviewer @user1.

Suggested Reviewers
@stanhu, @tkuah, @DouweM, @dzaporozhets, @tigerwnz

If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

added backend label

	1 Warning
	82274eb2: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Thomas Hutterer (@thutterer) (UTC+2)	Dmitry Gruzd (@dgruzd) (UTC+2)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

marked this merge request as ready

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

removed backend label

requested review from @dbalexandre

@dbalexandre would you mind taking a look at this one? it's a small MR

removed workflowin dev label

added workflowin review label

added 1 commit

• 3b620cc3 - Trigger KeepAroundRefsCreatedEvent event only if SHAs are passed

Compare with previous version

added backend label

Allure report

allure-report-publisher generated test report!

review-qa-blocking: test report for 82274eb2

expand test summary

+-----------------------------------------------------------------------------------------+
|                                     suites summary                                      |
+------------------------------------+--------+--------+---------+-------+-------+--------+
|                                    | passed | failed | skipped | flaky | total | result |
+------------------------------------+--------+--------+---------+-------+-------+--------+
| Plan                               | 47     | 0      | 1       | 47    | 48    | ❗     |
| Create                             | 23     | 0      | 2       | 23    | 25    | ❗     |
| Manage                             | 38     | 0      | 2       | 40    | 40    | ❗     |
| Verify                             | 12     | 0      | 1       | 12    | 13    | ❗     |
| Secure                             | 2      | 0      | 0       | 2     | 2     | ❗     |
| Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
| Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
| Protect                            | 2      | 0      | 0       | 2     | 2     | ❗     |
| Feature flag handler sanity checks | 9      | 0      | 0       | 9     | 9     | ❗     |
+------------------------------------+--------+--------+---------+-------+-------+--------+
| Total                              | 133    | 0      | 9       | 135   | 142   | ❗     |
+------------------------------------+--------+--------+---------+-------+-------+--------+