Change vulnerabilityFindingDismiss mutation to use uuid argument
What does this MR do and why?
This MR adds the uuid
argument for the vulnerabilityFindingDismiss mutation as the preferred search parameter and deprecates the use of id
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
- Run a pipeline to generate vulnerabilities
- Get a finding uuid
query {
project(fullPath:"<project path>") {
pipelines(first:1) {
nodes {
securityReportFindings(first:1) {
nodes {
uuid
}
}
}
}
}
}
mutation {
vulnerabilityFindingDismiss(input:{uuid:"<finding uuid>"}) {
finding {
title
}
}
}
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #360478 (closed)
Merge request reports
Activity
changed milestone to %15.2
assigned to @jschafer
removed [deprecated] Accepting merge requests label
added workflowin dev label and removed workflowready for development label
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@psimyn
,@jivanvl
,@mayra-cabrera
,@nick.thomas
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
- A deleted user
added documentation label
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/api/graphql/reference/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tarun Vellishetty ( @tvellishetty
) (UTC+5.5, 10.5 hours ahead of@jschafer
)Kerri Miller ( @kerrizor
) (UTC-7, 2 hours behind@jschafer
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #360478 (closed)
- Resolved by Pavel Shutsin
@rzwambag can you do the backend review please?
@claytoncornell can you review the documentation please?
added workflowin review label and removed workflowin dev label
requested review from @claytoncornell and @rzwambag
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
@rzwambag
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links: