Add help text to colour widget on Create Epic page
What does this MR do and why?
Blocked until !90144 (merged) has been merged
Adds help text to the Colour Widget input when creating a new epic
Screenshots or screen recordings
How to set up and validate locally
- Enable the
epic_color_highlight
feature flagFeature.enable(:epic_color_highlight)
- Visit a create epic page
http://gdk.test:3000/groups/flightjs/-/epics/new
- Review the description of the Colour widget
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #365949 (closed)
Merge request reports
Activity
Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
- Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
- If you haven't, please set up a
DANGER_GITLAB_API_TOKEN
. - You can comment
@gitlab-bot label ~"group::<group name>"
to add a group label or@gitlab-bot label ~"type::<type name>"
to add a type label. - When you're ready for a first review, just post
@gitlab-bot request_review
, and we'll take care of the rest. - If you need help moving the merge request forward, feel free to post
@gitlab-bot help
. - Read more on how to get help.
This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @espadav8
mentioned in merge request !90144 (merged)
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Hinam Mehra ( @hmehra
) (UTC+10)Robert Hunt ( @rob.hunt
) (UTC+1)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Andrew Smith@gitlab-bot ready @uhlexsis
added workflowready for review label and removed workflowin dev label
requested review from @uhlexsis
- Resolved by Andrew Smith
I love this idea @espadav8 @kushalpandya
Let's style this more as a form per tips in Pajamas (helping users, forms). This would just require adding a description to this input with that copy instead of the icon/tooltip.
Also, since this color will be used outside of the roadmap- maybe we could geenralize the copy a bit. I am thinking something like:
Configure the color that will be displayed with this epic wherever it is visualized.
WDYT of this copy @mushakov ? cc @msedlakjakubowski when he is back too since associating this with docs at some point is a great idea as well.This could look something like this:
Edited by Alexis Ginsberg
mentioned in issue gitlab-org/quality/triage-reports#8084 (closed)
mentioned in issue gitlab-org/quality/triage-reports#8088 (closed)
mentioned in merge request !90979 (merged)
mentioned in issue gitlab-org/quality/triage-reports#8133 (closed)
added devopsplan groupproduct planning labels
added featureenhancement typefeature labels
added 419 commits
-
8cd07d0d...a7e5bdfa - 418 commits from branch
gitlab-org:master
- 5fffe484 - Add tooltip to Colour label on new epic page
-
8cd07d0d...a7e5bdfa - 418 commits from branch
added sectiondev label
added UX label
removed review request for @uhlexsis
- Resolved by Andrew Smith
@patrickbajao, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
requested review from @patrickbajao
added 1412 commits
-
5fffe484...045f222f - 1411 commits from branch
gitlab-org:master
- c1e3f656 - Add tooltip to Colour label on new epic page
-
5fffe484...045f222f - 1411 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added workflowin dev label and removed workflowready for review label
added Technical Writing label
added 1 commit
- 85627387 - Add tooltip to Colour label on new epic page
@gitlab-bot ready @kpaizee
added workflowready for review label and removed workflowin dev label
requested review from @kpaizee
- Resolved by Robert Hunt
@patrickbajao @kpaizee, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
removed review request for @patrickbajao
removed review request for @kpaizee
- Resolved by Robert Hunt
@kpaizee
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
- Resolved by Robert Hunt
removed review request for @tbulva
requested review from @rob.hunt
changed milestone to %15.2