Skip to content

Fix testing category Redis HLL metrics

What does this MR do and why?

This MR is follow up to !90237 (merged) It fixes testing known events category enabling it to be collected with instrumentation classes framework

Broken metrics for testing category suffered from number of issues:

  1. Total metrics were misplaced. However after inspecting their metric definitions (total weekly and total monthly) it appeared that those metrics are removed. Therefore instead of fixing their instrumentation, testing category was removed as category eligible for total metrics, as those metrics are removed by ServicePing::BuildPayload
  2. EE only metrics were instrumented in CE code resulting in failing build for CE. If metric has metric definition YAML file in EE only, it will be filtered out from Service Ping payload on CE regardless if metric is instrumented in CE

Commit history showcase step by step process that I took in order to fix testing category

Relates #338463 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Compare payload from master and current branch to notice that there is no difference

pry(main)> ServicePing::BuildPayload.new.execute["redis_hll_counters"]["testing"]["testing_total_unique_counts_monthly"]
=> nil

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mikołaj Wawrzyniak

Merge request reports