Skip to content

Fix ide_edit known events total metrics definition

What does this MR do and why?

This MR is follow up to !90237 (merged) It fixes ide_edit known events total metrics definition enabling them to be collected with instrumentation classes framework

Relates #338463 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

pry(main)> ::Feature.enable(:use_redis_hll_instrumentation_classes)

pry(main)> Gitlab::UsageDataCounters::HLLRedisCounter.unique_events_data['ide_edit']
=> nil

pry(main)> ServicePing::BuildPayload.new.execute[:redis_hll_counters]['ide_edit']
=> {"g_edit_by_web_ide_weekly"=>0, "g_edit_by_web_ide_monthly"=>0, "g_edit_by_sfe_weekly"=>0, "g_edit_by_sfe_monthly"=>0, "g_edit_by_snippet_ide_weekly"=>0, "g_edit_by_snippet_ide_monthly"=>0, "g_edit_by_live_preview_weekly"=>0, "g_edit_by_live_preview_monthly"=>0, "ide_edit_total_unique_counts_weekly"=>0, "ide_edit_total_unique_counts_monthly"=>0}

pry(main)> ::Feature.disable(:use_redis_hll_instrumentation_classes)

pry(main)> Gitlab::UsageDataCounters::HLLRedisCounter.unique_events_data['ide_edit']
=> {"g_edit_by_web_ide_weekly"=>0, "g_edit_by_web_ide_monthly"=>0, "g_edit_by_sfe_weekly"=>0, "g_edit_by_sfe_monthly"=>0, "g_edit_by_snippet_ide_weekly"=>0, "g_edit_by_snippet_ide_monthly"=>0, "g_edit_by_live_preview_weekly"=>0, "g_edit_by_live_preview_monthly"=>0, "ide_edit_total_unique_counts_weekly"=>0, "ide_edit_total_unique_counts_monthly"=>0}

pry(main)> ServicePing::BuildPayload.new.execute[:redis_hll_counters]['ide_edit']
=> {"g_edit_by_web_ide_weekly"=>0, "g_edit_by_web_ide_monthly"=>0, "g_edit_by_sfe_weekly"=>0, "g_edit_by_sfe_monthly"=>0, "g_edit_by_snippet_ide_weekly"=>0, "g_edit_by_snippet_ide_monthly"=>0, "g_edit_by_live_preview_weekly"=>0, "g_edit_by_live_preview_monthly"=>0, "ide_edit_total_unique_counts_weekly"=>0, "ide_edit_total_unique_counts_monthly"=>0}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mikołaj Wawrzyniak

Merge request reports