Skip to content

Log SearchController search timings to determine service levels

Roy Zwambag requested to merge 342072-measure-global-search-time into master

What does this MR do and why?

This is an MR to measure search timings for web. It should hit both advanced and basic search (show method is inherited in /ee). This way we know the service levels for the error budget work.

next steps would be:

  • Similar work for the Search API
  • Expose the new metrics in prometheus (so we can actually save the metrics) (From what I can tell this is done automatically?)
  • Get success rate split up by basic/advanced, level, scope
  • specs

How to set up and validate locally

To enable Gitlab::Metrics middleware locally, comment out this part https://gitlab.com/gitlab-org/gitlab/-/blob/master/config/initializers/zz_metrics.rb#L17

Then it should show up at http://localhost:3000/-/metrics

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #342072 (closed)

Edited by Roy Zwambag

Merge request reports