Skip to content
Snippets Groups Projects

Add Metrics & Instrumentation for Incident timeline events

Merged Rajendra Kadam requested to merge 345187-incident-timelines-metrics into master

What does this MR do and why?

Adds instrumentation metrics for incident timeline events actions. It tracks create, edit, and delete.

Updated specs for create, edit and delete service to check for tracking calls.

Screenshots or screen recordings

NA

How to set up and validate locally

  1. Check from rails console that there are no events registered for create, edit, and delete actions using Gitlab::UsageDataCounters::HLLRedisCounter.unique_events(event_names: 'incident_management_timeline_event_*', start_date: Date.current.beginning_of_week, end_date: Date.current.next_week). Here * stands for created, edited, and deleted.
  2. Run create, edit, or delete actions via GraphQL API as there is no frontend for this feature yet. Follow the steps mentioned in the respective MR for actions.
  3. Run the line from point 1 in the console and check the value change from 0 to 1. It counts the unique user count performing those actions.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #345187 (closed)

Edited by Rajendra Kadam

Merge request reports

Merged results pipeline #566369887 passed with warnings

Pipeline: GitLab

#566374360

    Merged results pipeline passed with warnings for 984f56f7

    Test coverage 84.98% from 2 jobs

    Merged by Alper AkgunAlper Akgun 2 years ago (Jun 17, 2022 11:32am UTC)

    Loading

    Pipeline #566445631 failed

    Pipeline: GitLab

    #566458635

      Pipeline: omnibus-gitlab-mirror

      #566459192

        Pipeline failed for 1b074ae3 on master

        Test coverage 86.08% from 2 jobs
        8 environments impacted.

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
        Please register or sign in to reply
        Loading