Add Metrics & Instrumentation for Incident timeline events
What does this MR do and why?
Adds instrumentation metrics for incident timeline events actions. It tracks create
, edit
, and delete
.
Updated specs for create, edit and delete service to check for tracking calls.
Screenshots or screen recordings
NA
How to set up and validate locally
- Check from rails console that there are no events registered for
create
,edit
, anddelete
actions usingGitlab::UsageDataCounters::HLLRedisCounter.unique_events(event_names: 'incident_management_timeline_event_*', start_date: Date.current.beginning_of_week, end_date: Date.current.next_week)
. Here*
stands forcreated
,edited
, anddeleted
. - Run create, edit, or delete actions via GraphQL API as there is no frontend for this feature yet. Follow the steps mentioned in the respective MR for actions.
- Run the line from point 1 in the console and check the value change from
0
to1
. It counts the unique user count performing those actions.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #345187 (closed)
Merge request reports
Activity
changed milestone to %15.1
assigned to @rkadam3
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @splattael
,@ck3g
,@seanarnold
,@rkadam3
,@alexkalderimis
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender BotReviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Brian Williams ( @bwill
) (UTC-5, 10.5 hours behind@rkadam3
)Alex Pooley ( @alexpooley
) (UTC+8, 2.5 hours ahead of@rkadam3
)product intelligence Tarun Vellishetty ( @tvellishetty
) (UTC+5.5, same timezone as@rkadam3
)Maintainer review is optional for product intelligence To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 6e276869expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 23 | 0 | 2 | 22 | 25 | ❗ | | Manage | 36 | 0 | 2 | 37 | 38 | ❗ | | Plan | 48 | 0 | 1 | 48 | 49 | ❗ | | Secure | 6 | 0 | 0 | 6 | 6 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 127 | 0 | 9 | 127 | 136 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Usermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
removed workflowready for development label
removed missed-deliverable label
removed missed:15.0 label
added backend label
mentioned in commit bfcbe30a
added 153 commits
-
831261e9...4dbd544c - 152 commits from branch
master
- bfcbe30a - Add yml files for tracking incident timeline actions
-
831261e9...4dbd544c - 152 commits from branch
- Resolved by Alper Akgun
@pedropombeiro - Can you help with initial backend review?
@pskorupa - Can you help with product intelligence review?
Thanks!