Close the edit board modal with ESC or outside click
requested to merge zillemarco/gitlab:zillemarco-close-edit-board-with-escape-and-outside-click into master
What does this MR do and why?
Related to #365119 and #365118.
Collaboration between me, @leetickett and @espadav8 during our pairing session.
This MR adds the option to close the edit board modal by using the escape key or by clicking outside the modal itself.
When the modal was implemented @uhlexsis on this comment pointed out that users should only be able to close that modal by using the Apply or Cancel buttons but that's agains Pajamas designs as described here
Screenshots or screen recordings
| Old behavior | New behavior |
|---|---|
| Registrazione_schermo_2022-06-14_alle_21.23.04 | Registrazione_schermo_2022-06-14_alle_21.10.01 |
How to set up and validate locally
To test these changes you only need to try to edit a board and see that, by clicking outside the modal or by using the escape key, the modal gets closed.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Marco Zille