Replace DeprecatedModal with GlModal for boards

changed milestone to %13.7

added [deprecated] Accepting merge requests component:modal devopsplan frontend groupproduct planning pajamasintegrate sectiondev typemaintenance workflowin dev labels

added typefeature label

added 1 commit

ef813e71 - Replace DeprecatedModal with GlModal for boards

Compare with previous version

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, run the following:

bin/changelog -m 48647 "Replace DeprecatedModal with GlModal for boards"

If you want to create a changelog entry for GitLab EE, run the following instead:

bin/changelog --ee -m 48647 "Replace DeprecatedModal with GlModal for boards"

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
frontend	Tom Quirk (`@tomquirk`) (UTC+9.5, 0.5 hours behind `@fguibert`)	David O'Regan (`@oregand`) (UTC+0, 10 hours behind `@fguibert`)
test Quality for `spec/features/*`	Désirée Chevalier (`@dchevalier2`) (UTC-5, 15 hours behind `@fguibert`)	Maintainer review is optional for test Quality for `spec/features/*`

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed the description

added 1 commit

794736c3 - Replace DeprecatedModal with GlModal for boards

Compare with previous version

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 0860559f and 80d2b143

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.02 MB	3.02 MB	-	0.0 %
mainChunk	1.87 MB	1.87 MB	-	0.0 %

Significant Growth: 2

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.groups.boards	1.97 MB	2.03 MB	+69.66 KB	3.5 %
pages.projects.boards	1.98 MB	2.05 MB	+69.66 KB	3.4 %

Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

Note: We do not have exact data for 0860559f. So we have used data from: d9aa0aae.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

Read more about how this report works.

Generated by Danger

@uhlexsis This is ready for UX review. Using the new modal slightly changes their width. I used the same buttons for the primary actions but I thought you might want to double check.

EDIT: Actually maintaining the width by making sure the CSS gets applied. Let me know if we want to change anything there to follow pajamas design.