Fix static translations in integrations
What does this MR do and why?
We need to wrap these in a proc, otherwise they're evaluated when the class is loaded and will always be in English.
For the CI integrations this was an oversight when we refactored them to use the DSL in !86453 (merged).
The validation message in Jira was a pre-existing bug which we noticed
due to the improvements to the StaticTranslationDefinition
cop in
!89945 (merged).
This also adds missing specs for all Jira validations.
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Go to http://localhost:3000/-/profile/preferences and change your language to
Chinese, Simplified
- Go to http://localhost:3000/gitlab-org/gitlab-test/-/settings/integrations/jenkins/edit (or any other project)
- Verify that the labels and help texts for the form fields are translated correctly.
- Optional: Change your language back to English
😀
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Markus Koller