Use field DSL in CI integrations
What does this MR do and why?
Replace the prop_accessor
and #fields
definition with the field
DSL.
No functional changes, except for some reordering in the Buildkite and DroneCi integrations so the URL field comes first.
Fixes #354190 (closed), #354188 (closed), #354183 (closed), #354171 (closed), #354167 (closed), #354166 (closed)
Screenshots or screen recordings
For the reordering:
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Open each integration form in the project settings.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added groupintegrations [DEPRECATED] sectiondev typemaintenance + 1 deleted label
assigned to @toupeira
- Resolved by Alex Pooley
changed milestone to %15.0
@alexkalderimis could you please give this a review?
requested review from @alexkalderimis
added workflowin review label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Pedro Pombeiro ( @pedropombeiro
) (UTC+2, same timezone as@toupeira
)Alex Pooley ( @alexpooley
) (UTC+8, 6 hours ahead of@toupeira
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 1ad5c522expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Create | 18 | 0 | 2 | 4 | ❗ | | Plan | 41 | 0 | 1 | 4 | ❗ | | Manage | 28 | 0 | 2 | 18 | ❗ | | Verify | 12 | 0 | 1 | 8 | ❗ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Protect | 2 | 0 | 0 | 0 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Package | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 101 | 0 | 9 | 34 | ❗ | +----------------------+--------+--------+---------+-------+--------+
- Resolved by Markus Koller
Nice! Thanks for doing these ones @toupeira
@alexkalderimis
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Alex Pooley
@alexpooley - could you please give this MR a backend maintainer review?
requested review from @alexpooley and removed review request for @alexkalderimis
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @arturoherrero
,@smcgivern
,@georgekoltsov
,@rymai
,@ifarkas
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
enabled an automatic merge when the pipeline for a09dfe41 succeeds
mentioned in commit 3f0cb56a
added workflowstaging-canary label and removed workflowin review label
mentioned in issue #354166 (closed)
mentioned in issue #354167 (closed)
mentioned in issue #354171 (closed)
mentioned in issue #354183 (closed)
mentioned in issue #354188 (closed)
mentioned in issue #354190 (closed)
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1040 (merged)
mentioned in commit 1bb8f40d
mentioned in commit d399ebfb
mentioned in merge request !89833 (merged)
mentioned in commit 84c9093b
added releasedpublished label and removed releasedcandidate label
mentioned in issue #369599 (closed)
added devopsmanage label and removed 1 deleted label
added groupimport and integrate label and removed groupintegrations [DEPRECATED] label