This MR is related to the remaining unfixed Gitlab/NamespacedClass
cop warnings and their interaction with the REVEAL_RUBOCOP_TODO
functionality you added in !53162 (diffs)
In the RubyMine IDE, there's no way to selectively disable individual cops for the RuboCop plugin, which results in every single model
and lib
class having every line of the entire file underlined as an error.
This is not only hard to read, it masks all other warnings and errors within the class. Example:
Example of visual usability problems and masked warnings:
Open lib/gitlab/fips.rb
in RubyMine, see that the visual problems no longer exist.
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.