Remove language type from security training provider resolver and finder
We introduced language parameter in security training finders and GraphQL resolver in this issue. But later we decided to pass the filename instead of language type as part of #362697 (closed) which is merged in 15.1. As we are taking filename
from where we will derive the language in backend, we can get rid of language
parameter.
We are not going in the route to GraphQL deprecation as this parameter is introduced in 15.0(expired) and not used/consumed anywhere else (which was built for frontend in the first place).
Related to #364033 (closed)
Merge request reports
Activity
changed milestone to %15.1
assigned to @subashis
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @ahegyi
,@aqualls
,@.luke
,@splattael
,@Quintasan
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
2 Messages 📖 This merge request adds or changes files that require a review from the Database team. 📖 This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
ee/app/finders/security/training_urls_finder.rb
ee/app/finders/security/training_urls_finder.rb
Documentation review
The following files require a review from a technical writer:
doc/api/graphql/reference/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Roy Zwambag ( @rzwambag
) (UTC+2, 8 hours ahead of@subashis
)Luke Duncalfe ( @.luke
) (UTC+12, 18 hours ahead of@subashis
)database Dmytro Biryukov ( @dbiryukov
) (UTC+2, 8 hours ahead of@subashis
)Adam Hegyi ( @ahegyi
) (UTC+2, 8 hours ahead of@subashis
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
🚫 DangerEdited by Ghost Usermentioned in commit ef42a109
- Resolved by Douglas Barbosa Alexandre
@ghavenga Can you please do the initial review for this MR?
I think database review is not necessary as the changes here don't actually interact with the database.
requested review from @ghavenga
added workflowin review label and removed workflowin dev label
mentioned in commit 6199b6c8
added 179 commits
-
ef42a109...86ef6565 - 178 commits from branch
master
- 6199b6c8 - Remove language arg
-
ef42a109...86ef6565 - 178 commits from branch
👋 @ghavenga
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Douglas Barbosa Alexandre
Apologies @subashis, I'm unexpectedly OOO this week. Please choose another reviewer
🙇
removed review request for @cablett