Skip to content
Snippets Groups Projects

Add conditional access role options to access tokens view

Merged charlie ablett requested to merge cablett-permissible-access-level-roles-for-project into master
All threads resolved!

What does this MR do and why?

Making the access token dropdown in the UI change based on the current user's ability to manage different roles.

  • For Maintainers, the dropdown should only show Guest, Reporter, Developer, Maintainer
  • For Owners, the dropdown should also show Owner

Screenshots or screen recordings

As an owner:

Before

image

After

image

As a maintainer:

Before

image

After

image

How to set up and validate locally

  • As a Maintainer, go to a project's access tokens settings page (e.g. https://gdk.test:3443/mygroup/myproject/-/settings/access_tokens)
    • See the dropdown does not contain Owner
  • As an Owner, view the same page
    • See the dropdown contains Owner

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Sort of related to #21432 (closed)

Edited by charlie ablett

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • charlie ablett changed milestone to %15.1

    changed milestone to %15.1

  • charlie ablett requested review from @abdwdd

    requested review from @abdwdd

  • Abdul Wadood
  • Abdul Wadood removed review request for @abdwdd

    removed review request for @abdwdd

  • charlie ablett requested review from @abdwdd

    requested review from @abdwdd

  • Evan Read requested review from @fneill

    requested review from @fneill

  • Abdul Wadood removed review request for @abdwdd

    removed review request for @abdwdd

  • charlie ablett added 1 commit

    added 1 commit

    • 5cbaf935 - Refactor out some common code

    Compare with previous version

  • charlie ablett added 1 commit

    added 1 commit

    • f458a305 - Add conditional access role options to access tokens view

    Compare with previous version

  • charlie ablett requested review from @abdwdd

    requested review from @abdwdd

  • charlie ablett added 1783 commits

    added 1783 commits

    Compare with previous version

  • Abdul Wadood
  • Abdul Wadood approved this merge request

    approved this merge request

  • Abdul Wadood removed review request for @abdwdd

    removed review request for @abdwdd

  • charlie ablett added 1 commit

    added 1 commit

    • 54a228f3 - Add conditional access role options to access tokens view

    Compare with previous version

  • charlie ablett requested review from @.luke

    requested review from @.luke

  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe removed review request for @.luke

    removed review request for @.luke

  • charlie ablett added 1 commit

    added 1 commit

    • 472d26aa - Add conditional access role options to access tokens view

    Compare with previous version

  • charlie ablett added 1 commit

    added 1 commit

    • bfba9327 - Add method to project helper

    Compare with previous version

  • charlie ablett added 1 commit

    added 1 commit

    • e0f62c15 - Add method to project helper

    Compare with previous version

  • charlie ablett added 1 commit

    added 1 commit

    • 8b62e235 - Add method to project helper

    Compare with previous version

  • charlie ablett added 1 commit

    added 1 commit

    • b13b128c - Add conditional access role options to access tokens view

    Compare with previous version

  • charlie ablett added 226 commits

    added 226 commits

    Compare with previous version

  • charlie ablett added 1 commit

    added 1 commit

    • 417a7db3 - Add conditional access role options to access tokens view

    Compare with previous version

  • charlie ablett requested review from @.luke

    requested review from @.luke

  • charlie ablett added 1 commit

    added 1 commit

    • 97b1b934 - Add conditional access role options to access tokens view

    Compare with previous version

  • charlie ablett added 1 commit

    added 1 commit

    Compare with previous version

  • Luke Duncalfe approved this merge request

    approved this merge request

  • Luke Duncalfe resolved all threads

    resolved all threads

  • Luke Duncalfe enabled an automatic merge when the pipeline for 304d47a3 succeeds

    enabled an automatic merge when the pipeline for 304d47a3 succeeds

  • @cablett This looks great to me! Roulette is recommending frontend reviews - I feel confident with skipping this and merging now. I've set to merge when the pipeline succeeds :rocket:.

  • charlie ablett aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • charlie ablett added 1 commit

    added 1 commit

    Compare with previous version

  • charlie ablett added 1 commit

    added 1 commit

    • 08c8136e - Add conditional access role options to access tokens view

    Compare with previous version

  • Luke Duncalfe enabled an automatic merge when the pipeline for f102e9d8 succeeds

    enabled an automatic merge when the pipeline for f102e9d8 succeeds

  • charlie ablett aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • charlie ablett added 1 commit

    added 1 commit

    • 447b5ece - Add conditional access role options to access tokens view

    Compare with previous version

  • Luke Duncalfe enabled an automatic merge when the pipeline for d0897d28 succeeds

    enabled an automatic merge when the pipeline for d0897d28 succeeds

  • merged

  • Luke Duncalfe mentioned in commit d51830ba

    mentioned in commit d51830ba

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading