Skip to content

Fix issue description list item styling

Coung Ngo requested to merge cngo-fix-drag-list-item-styling into master

What does this MR do and why?

This MR :

  1. Fixes wrong vertical alignment for list items
  2. Fixes indentation so it only happens on multi-paragraph list items.

The bad alignment of checkboxes and labels was caused by vertical-align: top which we need for aligning the inside bullet point, so we need to exclude checkboxes and labels from the selector.

Previous related MRs: !85936 (merged) and !87904 (merged)

Changelog: fixed

Markdown used for testing
  1. Learn about GitLab Pages
    1. Read GitLab Pages
    2. Read Custom domains and SSL/TLS Certificates
  2. The elastic logs show traversal.ids @root ~Afternix

text

  1. multiline

    blockquote

    codeblock

    multi
    line
    codeblock

    emphasis

    header

    header 2

    ![img][img.jpg]


    link

    #F00

    👍

    • addition 2
    • addition 1
    • deletion 3
    • deletion 4
    a^2+b^2=c^2
    • Completed task
    • Incomplete task
      • Sub-task 1
      • Sub-task 2
      • Sub-task 3
    1. Completed task
    2. Incomplete task
      1. Sub-task 1
      2. Sub-task 2

    @root

    #1 (closed)

    ~Afternix

    Sample Video

    Sample Audio

    i am an img tag

    i am code

    Definition list
    Is something people use sometimes.
    Markdown in HTML
    Does *not* work **very** well. HTML tags do work, in most cases.
    Click this to collapse/fold.

    These details remain hidden until expanded.

    PASTE LOGS HERE
    Tables Are Cool
    col 3 is right-aligned $1600
    col 2 is centered $12
    zebra stripes are neat $1

List A

  • Blah
  • Another thing

List A with space

  • Blah

  • Another thing

Screenshots or screen recordings

before after
Screenshot_2022-05-24_at_1.37.44_pm Screenshot_2022-05-24_at_2.10.11_pm

How to set up and validate locally

  1. Visit an issue page such as http://127.0.0.1:3000/h5bp/html5-boilerplate/-/issues/1
  2. Update the issue description then test the MR

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Coung Ngo

Merge request reports

Loading