Skip to content

500 error on MR approvers edit page

Observed on gitlab.com.

worker2 production.log: Completed 500 Internal Server Error in 287ms (ActiveRecord: 11.7ms)
worker2 production.log: 
worker2 production.log: ActionView::Template::Error (undefined method `name' for nil:NilClass):
worker2 production.log:     54:         %ul.well-list
worker2 production.log:     55:           - @project.approvers.each do |approver|
worker2 production.log:     56:             %li
worker2 production.log:     57:               = link_to approver.user.name, approver.user
worker2 production.log:     58:               .pull-right
worker2 production.log:     59:                 = link_to namespace_project_approver_path(@project.namespace, @project, approver), data: { confirm: "Are you sure you want to remove approver #{approver.user.name}"}, method: :delete, class: "btn-xs btn btn-remove", title: 'Remove approver' do
worker2 production.log:     60:                   = icon("sign-out")
worker2 production.log:   app/views/projects/_merge_request_settings.html.haml:57:in `block in _app_views_projects__merge_request_settings_html_haml___545752523034962009_57962180'

I checked the Rails console, this project has a number of approvers but the user ID of the last one is 0.

cc @sytses @vsizov

Edited by Iris Blackburn