Add top margin for auto fix card on vulnerability report
This MR adds a top margin for the auto fix card on the vulnerability report, so that it doesn't butt up either against the warning above it, or the dividing line above it:
With warning
Before | After |
---|---|
![]() |
![]() |
Without warning
Before | After |
---|---|
![]() |
![]() |
How to verify
The warning and cards are hidden forever once they're dismissed. The easiest way to get them to show again is to create a new user and set it as an auditor:
![]() |
Then log in as the user and go to any vulnerability report. The warning and cards should show.
Related to #362201 (closed)
Merge request reports
Activity
assigned to @dftian
mentioned in commit 472ab152
added 279 commits
-
1ae79493...9d0c6519 - 278 commits from branch
master
- 472ab152 - Add top margin to auto fix card on vulnerability report
-
1ae79493...9d0c6519 - 278 commits from branch
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @kushalpandya
,@iamphill
,@jcaigitlab
,@rymai
,@rspeicher
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
requested review from @pgascouvaillancourt
@pgascouvaillancourt Would you be able to do the review for this one?
- A deleted user
added typebug label
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Diana Zubova ( @dzubova
) (UTC+2, 12 hours ahead of@dftian
)Kushal Pandya ( @kushalpandya
) (UTC+5.5, 15.5 hours ahead of@dftian
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 69ae5207 and 925b1ecc
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.46 MB 3.46 MB - 0.0 % mainChunk 1.93 MB 1.93 MB - 0.0 %
Note: We do not have exact data for 69ae5207. So we have used data from: 682d4c3a.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 925b1eccexpand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Manage | 31 | 0 | 2 | 29 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Protect | 2 | 0 | 0 | 2 | ❗ | | Plan | 41 | 0 | 1 | 41 | ❗ | | Create | 24 | 0 | 2 | 22 | ❗ | | Verify | 12 | 0 | 1 | 12 | ❗ | | Configure | 0 | 0 | 1 | 0 | ➖ | | Package | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 110 | 0 | 9 | 106 | ❗ | +----------------------+--------+--------+---------+-------+--------+
Edited by Ghost Userrequested review from @mlunoe and removed review request for @pgascouvaillancourt
@pgascouvaillancourt
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
mentioned in commit 47fe7fd0
added 284 commits
-
472ab152...c605916c - 283 commits from branch
master
- 47fe7fd0 - Add top margin to auto fix card on vulnerability report
-
472ab152...c605916c - 283 commits from branch
mentioned in commit 925b1ecc