Bring Container Scanning to Free
Why are we doing this work
We want to bring Container Scanning to Free.
documentation -> !86960 (merged)
Related to #355307 (closed)
Merge request reports
Activity
changed milestone to %15.0
assigned to @bauerdominic
Suggested Reviewers (beta)
This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".
The individuals below may be good candidates to participate in the review based on various factors.
After you review all recommendations, please assign reviewers manually, as this is not done automatically.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Reviewers @eread
,@marcel.amirault
,@rymai
,@axil
,@rspeicher
If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot
Edited by GitLab Reviewer-Recommender Bot2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message This merge request adds or changes files that require a review from the CI/CD Templates maintainers. If needed, you can retry the
danger-review
job that generated this comment.This merge request requires a CI/CD Template review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has the citemplates label. If the merge request modifies CI/CD Template files, Danger will do this for you.
- Prepare your MR for a CI/CD Template review according to the template development guide.
- Assign and
@
mention the CI/CD Template reviewer suggested by Reviewer Roulette.
The following files require a review from the CI/CD Templates maintainers:
lib/gitlab/ci/templates/Security/Container-Scanning.gitlab-ci.yml
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Abdul Wadood ( @abdwdd
) (UTC+5.5, 3.5 hours ahead of@bauerdominic
)Sincheol (David) Kim ( @dskim_gitlab
) (UTC+9.5, 7.5 hours ahead of@bauerdominic
)citemplates Brian Williams ( @bwill
) (UTC-5, 7 hours behind@bauerdominic
)Sincheol (David) Kim ( @dskim_gitlab
) (UTC+9.5, 7.5 hours ahead of@bauerdominic
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for bc36f9e5expand test summary
+-------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+--------+ | | passed | failed | skipped | flaky | result | +----------------------+--------+--------+---------+-------+--------+ | Manage | 31 | 0 | 2 | 28 | ❗ | | Create | 24 | 0 | 2 | 19 | ❗ | | Package | 0 | 0 | 1 | 0 | ➖ | | Verify | 12 | 0 | 1 | 10 | ❗ | | Plan | 41 | 0 | 1 | 39 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | ➖ | | Protect | 2 | 0 | 0 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | ➖ | +----------------------+--------+--------+---------+-------+--------+ | Total | 110 | 0 | 9 | 98 | ❗ | +----------------------+--------+--------+---------+-------+--------+
requested review from @sashi_kumar
- Resolved by Sincheol (David) Kim
@sashi_kumar Could you review this please? Almost identical to your closed draft MR (thanks for that!)
removed [deprecated] Accepting merge requests label
@sashi_kumar
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Sincheol (David) Kim
@bwill Could you review citemplates please?
@dskim_gitlab Could you do the maintainer backend review please?
requested review from @bwill and @dskim_gitlab
removed review request for @bwill
removed review request for @sashi_kumar
mentioned in merge request !86960 (merged)
added 577 commits
-
41890437...23279e07 - 575 commits from branch
master
- f77432ec - Bring Container Scanning to Free
- bc36f9e5 - Update test case
-
41890437...23279e07 - 575 commits from branch
mentioned in issue #355309 (closed)
enabled an automatic merge when the pipeline for fce03c5d succeeds
mentioned in commit 365d217f
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1040 (merged)
added releasedpublished label and removed releasedcandidate label